Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the cmake commands for finding dependencies into a separate file #18

Merged
merged 6 commits into from Jul 8, 2017
Merged

Move all the cmake commands for finding dependencies into a separate file #18

merged 6 commits into from Jul 8, 2017

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Jul 8, 2017

In this Pull Request I continue with the cleaning/refactoring step of the CMake code.

This time I just move all the CMake commands that are used to find the dependencies into a new file. I also took this opportunity to do other improvements:

  • FindExpat.cmake has been removed. It is already included in CMake.
  • Remove CMAKE_REQUIRED_INCLUDES that was set but never used.
  • Remove some unneeded checks (already done internally in FindExpat)
  • Only try to find MSGFMT if we want to use it.

@clanmills
Copy link
Collaborator

Thank You for doing this @piponazo

I'm working hard on the CMake/static/external library stuff at the moment. I'll pull your code into master in a couple of hours when I've finished what I'm doing. I'm working on the same files that you have modified. I hope the weather's as beautiful for you as it is for us in England today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants