Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected JPEG XL file type #1824

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Corrected JPEG XL file type #1824

merged 3 commits into from
Aug 27, 2021

Conversation

1div0
Copy link
Collaborator

@1div0 1div0 commented Aug 1, 2021

Before:

€ exiv2 pr IMG_20210618_081111.jxl
File name       : IMG_20210618_081111.jxl
File size       : 1638062 Bytes
MIME type       : image/generic
Image size      : 3264 x 2448
Thumbnail       : image/jpeg, 15556 Bytes
Camera make     : LENOVO
Camera model    : Lenovo TAB3 10 Business
Image timestamp : 2021:06:18 08:11:11
File number     : 
Exposure time   : 0.000818 s
Aperture        : F2.2
Exposure bias   : 0 EV
Flash           : No flash
Flash bias      : 
Focal length    : 3.5 mm
Subject distance: 
ISO speed       : 94
Exposure mode   : Not defined
Metering mode   : Center weighted average
Macro mode      : 
Image quality   : 
White balance   : Auto
Copyright       : 
Exif comment    : 

After:

€ exiv2 pr IMG_20210618_081111.jxl
File name       : IMG_20210618_081111.jxl
File size       : 1638062 Bytes
MIME type       : image/jxl
Image size      : 3264 x 2448
Thumbnail       : image/jpeg, 15556 Bytes
Camera make     : LENOVO
Camera model    : Lenovo TAB3 10 Business
Image timestamp : 2021:06:18 08:11:11
File number     : 
Exposure time   : 0.000818 s
Aperture        : F2.2
Exposure bias   : 0 EV
Flash           : No flash
Flash bias      : 
Focal length    : 3.5 mm
Subject distance: 
ISO speed       : 94
Exposure mode   : Not defined
Metering mode   : Center weighted average
Macro mode      : 
Image quality   : 
White balance   : Auto
Copyright       : 
Exif comment    : 

In other words, MIME type was not correctly reported.

@1div0 1div0 requested a review from hassec August 1, 2021 12:04
src/bmffimage.cpp Outdated Show resolved Hide resolved
hassec
hassec previously requested changes Aug 1, 2021
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a look at the failing tests please?

@1div0
Copy link
Collaborator Author

1div0 commented Aug 1, 2021

Sure, but not today.

@kmilos kmilos added the enhancement feature / functionality enhancements label Aug 12, 2021
@kmilos kmilos requested a review from hassec August 15, 2021 14:44
@kevinbackhouse kevinbackhouse dismissed hassec’s stale review August 25, 2021 17:42

Tests are passing now

@kevinbackhouse kevinbackhouse merged commit ccfdcf8 into Exiv2:main Aug 27, 2021
@antermin
Copy link

0.27's code has the wrong tag, so I think we should also apply this to the 0.27 branch?

@kmilos
Copy link
Collaborator

kmilos commented Apr 4, 2023

@mergify backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

backport 0.27-maintenance

✅ Backports have been created

@kmilos kmilos added the imageHandler Anything related to specific ImageHandlers label Apr 4, 2023
kmilos added a commit that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements imageHandler Anything related to specific ImageHandlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants