Annotate some strings with xgettext:no-c-format #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some descriptions of location properties contain the text "100% overlap". When extracting text for translation, `xgettext` misidentifies this as containing the C format string "% o", and tags it as `c-format`. Translation tools that are sensitive to this will require that translations contain matching format strings; since in this case the format string is nonsensical, that is often not reasonably possible. See: https://answers.launchpad.net/launchpad/+question/698762 The description of the DotRange tag contains the text "0% dot and 100% dot", which is similarly misidentified. To fix this, inform `xgettext` that the messages do not contain C format strings, as documented here (towards the end): https://www.gnu.org/software/gettext/manual/html_node/c_002dformat-Flag.html
Codecov Report
@@ Coverage Diff @@
## main #1908 +/- ##
=======================================
Coverage 60.87% 60.87%
=======================================
Files 96 96
Lines 19041 19041
Branches 9726 9726
=======================================
Hits 11591 11591
Misses 5138 5138
Partials 2312 2312
Continue to review full report at Codecov.
|
kevinbackhouse
approved these changes
Sep 18, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some descriptions of location properties contain the text "100%
overlap". When extracting text for translation,
xgettextmisidentifies this as containing the C format string "% o", and tags it
as
c-format. Translation tools that are sensitive to this willrequire that translations contain matching format strings; since in this
case the format string is nonsensical, that is often not reasonably
possible. See:
https://answers.launchpad.net/launchpad/+question/698762
The description of the DotRange tag contains the text "0% dot and 100%
dot", which is similarly misidentified.
To fix this, inform
xgettextthat the messages do not contain C formatstrings, as documented here (towards the end):
https://www.gnu.org/software/gettext/manual/html_node/c_002dformat-Flag.html