Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CMake code for the case Win + CMake + Visual Studio #22

Merged
merged 7 commits into from
Aug 11, 2017
Merged

Improve CMake code for the case Win + CMake + Visual Studio #22

merged 7 commits into from
Aug 11, 2017

Commits on Aug 10, 2017

  1. exv_conf.h is now generated in the CMAKE_BINARY_DIR to not mess up th… 

    …e source tree.
    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    df899bf View commit details
    Browse the repository at this point in the history

  2. Since we are requiring CMake 3.1 we can remove the usage of PRIVATE_V… 

    …AR and use directly PRIVATE or PUBLIC
    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    b6885c8 View commit details
    Browse the repository at this point in the history

  3. Add XML_STATIC definition in xmp library to fix problems finding symb… 

    …ols. Link always with EXPAT_LIBARIES
    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    36e12a4 View commit details
    Browse the repository at this point in the history

  4. Only compile the xmp static library if EXIV2_ENABLE_LIBXMP is enabled

    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    a6dbbeb View commit details
    Browse the repository at this point in the history

  5. The geotag sample depends on EXIV2_ENABLE_LIBXMP

    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    291726a View commit details
    Browse the repository at this point in the history

  6. Do not propagate the EXPAT include directories for all the targets

    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    cf76fa5 View commit details
    Browse the repository at this point in the history

  7. Propagate EXPAT include directories and libraries with the xmp target

    @piponazo
    piponazo committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    acf8ebd View commit details
    Browse the repository at this point in the history