Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: remove const from data members #2572

Merged
merged 1 commit into from
Apr 3, 2023
Merged

clang-tidy: remove const from data members #2572

merged 1 commit into from
Apr 3, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Apr 1, 2023

Found with cppcoreguidelines-avoid-const-or-ref-data-members

Found with cppcoreguidelines-avoid-const-or-ref-data-members

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ghost
Copy link

ghost commented Apr 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #2572 (1281818) into main (0fa22ed) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #2572      +/-   ##
==========================================
- Coverage   63.90%   63.89%   -0.02%     
==========================================
  Files         103      103              
  Lines       22393    22397       +4     
  Branches    10824    10826       +2     
==========================================
  Hits        14310    14310              
- Misses       5864     5867       +3     
- Partials     2219     2220       +1     
Impacted Files Coverage Δ
include/exiv2/bmffimage.hpp 100.00% <ø> (ø)
include/exiv2/error.hpp 54.54% <ø> (ø)
src/basicio.cpp 50.58% <ø> (ø)
src/cr2header_int.hpp 0.00% <ø> (ø)
src/image_int.hpp 100.00% <ø> (ø)
src/makernote_int.cpp 65.85% <0.00%> (-0.50%) ⬇️
src/nikonmn_int.cpp 61.09% <ø> (ø)
src/sonymn_int.cpp 79.96% <ø> (ø)
src/tiffcomposite_int.hpp 97.27% <ø> (ø)
src/tiffimage_int.hpp 100.00% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit 3633f8d into Exiv2:main Apr 3, 2023
@neheb neheb deleted the cons branch April 3, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants