Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of 4 lenses Pentax #2583

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Addition of 4 lenses Pentax #2583

merged 1 commit into from
Apr 10, 2023

Conversation

gribouilleuse
Copy link
Contributor

Addition of 4 lenses Pentax :
HD Pentax-D FA* 50mm F1.4 SDM AW
HD Pentax-D FA 70-210mm F4 ED SDM WR
HD Pentax-D FA* 85mm F1.4 SDM AW
HD Pentax-D FA 21mm F2.4 ED Limited DC WR

Addition of 4 lenses Pentax :
HD Pentax-D FA* 50mm F1.4 SDM AW
HD Pentax-D FA 70-210mm F4 ED SDM WR
HD Pentax-D FA* 85mm F1.4 SDM AW
HD Pentax-D FA 21mm F2.4 ED Limited DC WR
@ghost
Copy link

ghost commented Apr 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb neheb merged commit 4074873 into Exiv2:main Apr 10, 2023
@kmilos
Copy link
Collaborator

kmilos commented Apr 11, 2023

Should probably have gone in w/ uppercase "PENTAX" for consistency, but at least lensfun matching is I think not case sensitive...

@gribouilleuse
Copy link
Contributor Author

Should probably have gone in w/ uppercase "PENTAX" for consistency, but at least lensfun matching is I think not case sensitive...

You're right, i will fix with uppercase

@kmilos kmilos added the lens Issue related to lens detection label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants