Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMFF: fix handling of boxes w/ zero length or type #2612

Merged
merged 1 commit into from
May 11, 2023
Merged

BMFF: fix handling of boxes w/ zero length or type #2612

merged 1 commit into from
May 11, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented May 10, 2023 •
edited
Loading

Fixes darktable-org/darktable#14473

These are valid going by the BMFF spec AFAICT.

@kmilos kmilos requested a review from 1div0 May 10, 2023 16:38
@kmilos kmilos added bug imageHandler Anything related to specific ImageHandlers labels May 10, 2023
@ghost
Copy link

ghost commented May 10, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (0.28.x@54700c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             0.28.x    #2612   +/-   ##
=========================================
  Coverage          ?   63.93%           
=========================================
  Files             ?      103           
  Lines             ?    22298           
  Branches          ?    10789           
=========================================
  Hits              ?    14257           
  Misses            ?     5823           
  Partials          ?     2218

1div0
1div0 previously approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Hvala.

@kmilos
Copy link
Collaborator Author

kmilos commented May 10, 2023 •
edited
Loading

Thanks, but the test still needs some work...

@kmilos kmilos marked this pull request as draft May 10, 2023 17:16
@mergify mergify bot dismissed 1div0’s stale review May 11, 2023 07:51

Pull request has been modified.

@kmilos kmilos marked this pull request as ready for review May 11, 2023 08:21
@kmilos kmilos requested a review from 1div0 May 11, 2023 08:21
kmilos added a commit that referenced this pull request May 11, 2023
@kmilos
BMFF: fix handling of boxes w/ zero length or type (backport #2612)
8e14663
@kmilos
Copy link
Collaborator Author

kmilos commented May 11, 2023

@Mergifyio backport main

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023 •
edited
Loading

backport main

✅ Backports have been created

1div0
1div0 approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobro. Hvala.

@kmilos kmilos merged commit 2876c8c into 0.28.x May 11, 2023
110 checks passed
@mergify mergify bot deleted the kmilos_fix_bmff_zero_box branch May 11, 2023 09:50
@mergify mergify bot mentioned this pull request May 11, 2023
Merged
kmilos added a commit that referenced this pull request May 11, 2023
@kmilos
Merge pull request #2614 from Exiv2/kmilos_fix_bmff_zero_box_027
611ce84 
BMFF: fix handling of boxes w/ zero length or type (backport #2612)
@kmilos kmilos mentioned this pull request Sep 7, 2023
Open
@etrigan63 etrigan63 mentioned this pull request Sep 7, 2023
Closed
@kmilos kmilos mentioned this pull request Oct 24, 2023
Closed
@kevinbackhouse kevinbackhouse added this to the v0.28.1 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1div0 1div0 1div0 approved these changes

Assignees
No one assigned
Labels
bug imageHandler Anything related to specific ImageHandlers
Projects
None yet
Milestone
v0.28.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmilos @1div0 @kevinbackhouse