Bump minimum cmake and stop creating build directory #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
neheb
reviewed
May 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #2622 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 103 103
Lines 22296 22298 +2
Branches 10787 10789 +2
=======================================
+ Hits 14255 14257 +2
Misses 5823 5823
Partials 2218 2218
|
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
kmilos
reviewed
May 17, 2023
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
kmilos
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the cmake version to match the version Ubuntu 20.04 now that Ubuntu 18.04 is EOL.
I updated the build instructions to use the method that doesn't require you to delete, create and change directories into a build directory to compile and test the code. The other advantage is you can now have multiple build directories while continuing to work in the same root directory.
Closes #2617