Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on NetBSD. #2625

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix build on NetBSD. #2625

merged 1 commit into from
May 17, 2023

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented May 16, 2023

NetBSD provides a libproc.h header, but no PROC_PIDPATHINFO_MAXSIZE symbol.

@ghost
Copy link

ghost commented May 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2625 (2d28d3b) into main (ec6c806) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         103      103           
  Lines       22298    22298           
  Branches    10789    10789           
=======================================
  Hits        14257    14257           
  Misses       5823     5823           
  Partials     2218     2218           
Impacted Files Coverage Δ
src/futils.cpp 73.09% <ø> (ø)

@kmilos kmilos added the platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc label May 17, 2023
@kmilos
Copy link
Collaborator

kmilos commented May 17, 2023

@neheb With recent Azure connection timeouts and the ridiculous number of tasks we have, passing the CI is becoming a lottery. I've lost the patience for re-submitting and waiting, I'm merging this as is.

@kmilos kmilos merged commit d92fb10 into Exiv2:main May 17, 2023
87 of 107 checks passed
@kmilos
Copy link
Collaborator

kmilos commented May 17, 2023

@Mergifyio backport 0.28.x

@mergify
Copy link
Contributor

mergify bot commented May 17, 2023

backport 0.28.x

✅ Backports have been created

@neheb
Copy link
Collaborator

neheb commented May 17, 2023

@kmilos does actiond use azure?

@kmilos
Copy link
Collaborator

kmilos commented May 17, 2023

I think some Ubuntu repositories are mirrored there, and GHA runners seem to pick them more often than not...

@neheb
Copy link
Collaborator

neheb commented May 17, 2023

Wouldn't doubt it. Ubuntu is involved with Microsoft IIRC. But so is GitHub...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platforms Cygwin, MinGW, cross-compilation, NetBSD, FreeBSD etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants