Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyaccess const changes #2667

Closed
wants to merge 1 commit into from
Closed

easyaccess const changes #2667

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jun 29, 2023

No description provided.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2667 (0072ebc) into main (6b186a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2667   +/-   ##
=======================================
  Coverage   63.92%   63.93%           
=======================================
  Files         103      103           
  Lines       22306    22312    +6     
  Branches    10795    10798    +3     
=======================================
+ Hits        14259    14265    +6     
  Misses       5826     5826           
  Partials     2221     2221           
Impacted Files Coverage Δ
src/easyaccess.cpp 93.84% <100.00%> (+0.29%) ⬆️

@ghost
Copy link

ghost commented Jun 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb
Copy link
Collaborator Author

neheb commented Jun 29, 2023

so GCC7 doesn't like this. hmmm.

@kmilos
Copy link
Collaborator

kmilos commented Jun 30, 2023

so GCC7 doesn't like this

Drop it already 😉

Some C++17 features are available since GCC 5, but support was experimental and the ABI of C++17 features was not stable until GCC 9.

@neheb neheb closed this Jun 30, 2023
@neheb neheb deleted the a branch July 7, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants