Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asf: fix GUID reading on big endian platforms #2694

Merged
merged 1 commit into from
Jul 17, 2023

Commits on Jul 16, 2023

  1. asf: fix GUID reading on big endian platforms

    Setting the initial parts (data1_, data2_, data3_) from the bytes
    directly using memcpy() means that they will be interpreted depending
    on the platform endianness. For example, the initial 4 bytes of the ASF
    header are 0x30, 0x26, 0xB2, 0x75, which will be read as 0x3026B275 on
    big endian platforms, never matching the actual GUID (0x75B22630), which
    is always specified in little endian format.
    
    Hence, when reading a GUID from data, make sure to turn the GUID parts
    to little endian. This fixes the reading of ASF files on big endian
    platforms.
    
    Fixes commit bed8d3d
    pinotree committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    235a117 View commit details
    Browse the repository at this point in the history