Improve easyaccess documentation #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
reviewed
Jul 20, 2023
include/exiv2/easyaccess.hpp
Outdated
Comment on lines
33
to
35
| //! Return the ISO speed used to shoot the image. Please keep in mind that this accessor is provided for convenience | ||
| //! only and will return expected/desired metadata most of the time. | ||
| EXIV2API ExifData::const_iterator isoSpeed(const ExifData& ed); |
There was a problem hiding this comment.
As there is some extra computation involved for ISO, maybe another sentence (similar to lens detection) is warranted?
|
@kmilos : I was not aware of this, thanks for the hint. Is following addition fine?
|
Great, thanks @norbertwg |
Codecov Report
@@ Coverage Diff @@
## main #2706 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 103 103
Lines 22313 22313
Branches 10804 10804
=======================================
Hits 14261 14261
Misses 5828 5828
Partials 2224 2224 |
kmilos
approved these changes
Jul 21, 2023
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to issue #2204 : Some explanations added to easyaccess API.