Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jp2image: fix IPTC & XMP UUIDs when writing #2890

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 10, 2024

Fixes #2884

@ghost
Copy link

ghost commented Jan 10, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos added bug imageHandler Anything related to specific ImageHandlers labels Jan 10, 2024
@kmilos kmilos added this to the v0.28.2 milestone Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (52d4451) 63.90% compared to head (e5133a2) 63.90%.

Files Patch % Lines
src/jp2image.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2890   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         104      104           
  Lines       22389    22389           
  Branches    10876    10876           
=======================================
  Hits        14308    14308           
  Misses       5857     5857           
  Partials     2224     2224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos kmilos removed this from the v0.28.2 milestone Jan 10, 2024
@kmilos kmilos merged commit 71bb2b1 into main Jan 11, 2024
64 checks passed
@kmilos
Copy link
Collaborator Author

kmilos commented Jan 11, 2024

@mergify backport 0.28.x

@kmilos kmilos deleted the kmilos/fix_jp2_uuid_wr branch January 11, 2024 09:23
Copy link
Contributor

mergify bot commented Jan 11, 2024

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug imageHandler Anything related to specific ImageHandlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing XMP metadata to jp2 files erases all XMP metadata in file
2 participants