Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis support #29

Merged
merged 3 commits into from Aug 20, 2017
Merged

Travis support #29

merged 3 commits into from Aug 20, 2017

Conversation

piponazo
Copy link
Collaborator

Adds travis support for building the project on Linux and Mac OSX with different configurations. It actually helped me to find some issues in the CMake code :)

- Installing requirements with install script
- Add missing include(checkIncludeFile) cmake command
- Configuration matrix to compile the project with different options
@clanmills clanmills merged commit 989c5e7 into Exiv2:master Aug 20, 2017
@piponazo piponazo deleted the travisSupport branch August 20, 2017 16:59
@clanmills
Copy link
Collaborator

Thanks very much for doing this, Luis. I hope you've had a nice weekend.

This hasn't solved the issue with libintl on MacOSX. However, I can see you're been changing stuff concerning linking exiv2 with other libraries. I've never investigated the .po files Thomas (our German Contributor), knows about them. For sure we initialise libintl from exiv2.cpp. I'm not sure the .po files are used by the library. If they are not, libintl shouldn't be linked to libexiv2. I'll email Thomas and ask him about this.

@clanmills
Copy link
Collaborator

Whoops, I spoke too soon. I've pulled down a fresh copy of the code from GitHub and it builds. Thanks for fixing this. And I'm delighted to see that CMake build is publishing the correct headers in /usr/local/include/exiv2.

@piponazo
Copy link
Collaborator Author

You are welcome :)

Right I did not check that yet, but now I can check it out even at home using travis.

The problem is that we are assuming the existence of Intl:

if( EXIV2_ENABLE_NLS )
    find_package(Intl)
    if(Intl_FOUND)

But I will experiment this week with that. It should be easily fixable ;)

@clanmills
Copy link
Collaborator

This seems totally splendid. Is there a Travis node actually building the code?

@piponazo
Copy link
Collaborator Author

Yes, but only on my fork:
https://travis-ci.org/piponazo/exiv2

I left you some messages on slack explaining the alternatives we have to enable the support in the main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants