Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc makernote updates #2954

Merged
merged 3 commits into from Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/nikonmn_int.cpp
Expand Up @@ -3969,7 +3969,7 @@ std::ostream& Nikon3MakerNote::printLensId4ZMount(std::ostream& os, const Value&
return os << "(" << value << ")";
}

// from https://github.com/exiftool/exiftool/blob/12.59/lib/Image/ExifTool/Nikon.pm#L5267
// cf. https://github.com/exiftool/exiftool/blob/12.83/lib/Image/ExifTool/Nikon.pm#L5473
static constexpr struct lens {
uint16_t l;
const char* vendor;
Expand Down Expand Up @@ -3998,7 +3998,7 @@ std::ostream& Nikon3MakerNote::printLensId4ZMount(std::ostream& os, const Value&
{28, "Nikon", "Nikkor Z 100-400mm f/4.5-5.6 VR S"}, // 28
{29, "Nikon", "Nikkor Z 28mm f/2.8"}, // IB
{30, "Nikon", "Nikkor Z 400mm f/2.8 TC VR S"}, // 28
{31, "Nikon", "Nikkor Z 24-120 f/4"}, // 28
{31, "Nikon", "Nikkor Z 24-120mm f/4 S"}, // 28
{32, "Nikon", "Nikkor Z 800mm f/6.3 VR S"}, // 28
{35, "Nikon", "Nikkor Z 28-75mm f/2.8"}, // IB
{36, "Nikon", "Nikkor Z 400mm f/4.5 VR S"}, // IB
Expand All @@ -4012,6 +4012,7 @@ std::ostream& Nikon3MakerNote::printLensId4ZMount(std::ostream& os, const Value&
{44, "Nikon", "Nikkor Z 70-180mm f/2.8"},
{45, "Nikon", "Nikkor Z 600mm f/6.3 VR S"},
{46, "Nikon", "Nikkor Z 135mm f/1.8 S Plena"},
{48, "Nikon", "Nikkor Z 28-400mm f/4-8 VR"},
{53251, "Sigma", "56mm F1.4 DC DN | C"},
{57346, "Tamron", "35-150mm F/2-2.8 Di III VXD"},
};
Expand Down
2 changes: 1 addition & 1 deletion src/sonymn_int.cpp
Expand Up @@ -548,7 +548,7 @@ constexpr StringTagDetails sonyFileFormat[] = {
{"0 0 0 2", "JPEG"}, {"1 0 0 0", "SR2 1.0"}, {"2 0 0 0", "ARW 1.0"}, {"3 0 0 0", "ARW 2.0"},
{"3 1 0 0", "ARW 2.1"}, {"3 2 0 0", "ARW 2.2"}, {"3 3 0 0", "ARW 2.3"}, {"3 3 1 0", "ARW 2.3.1"},
{"3 3 2 0", "ARW 2.3.2"}, {"3 3 3 0", "ARW 2.3.3"}, {"3 3 5 0", "ARW 2.3.5"}, {"4 0 0 0", "ARW 4.0"},
{"4 0 1 0", "ARW 4.0.1"}, {"5 0 0 0", "ARW 5.0.0"},
{"4 0 1 0", "ARW 4.0.1"}, {"5 0 0 0", "ARW 5.0.0"}, {"5 0 1 0", "ARW 5.0.1"},
};

//! Lookup table to translate Sony dynamic range optimizer values to readable labels
Expand Down
2 changes: 1 addition & 1 deletion src/tags_int.cpp
Expand Up @@ -1702,7 +1702,7 @@ constexpr TagInfo ifdTagInfo[] = {
"used if ColorPlanes is greater than 3. The matrix is stored in row "
"scan order."),
IfdId::ifd0Id, SectionId::dngTags, signedRational, -1, printValue}, // DNG 1.6 tag
{0xcd3b, "RGBTables", N_("RGB Tables"),
{0xcd3f, "RGBTables", N_("RGB Tables"),
N_("This tag specifies color transforms that can be applied to masked image "
"regions. Color transforms are specified using RGB-to-RGB color lookup tables. "
"These tables are associated with Semantic Masks to limit the color transform "
Expand Down
2 changes: 1 addition & 1 deletion test/data/test_reference_files/test_pr_1905_poc1_ref.out
Expand Up @@ -244,7 +244,7 @@ IlluminantData3,52535,0xcd37,Image,Exif.Image.IlluminantData3,Undefined,"When th
MaskSubArea,52536,0xcd38,Image,Exif.Image.MaskSubArea,Long,"This tag identifies the crop rectangle of this IFD's mask, relative to the main image."
ProfileHueSatMapData3,52537,0xcd39,Image,Exif.Image.ProfileHueSatMapData3,Float,"This tag contains the data for the third hue/saturation/value mapping table. Each entry of the table contains three 32-bit IEEE floating-point values. The first entry is hue shift in degrees; the second entry is saturation scale factor; and the third entry is a value scale factor. The table entries are stored in the tag in nested loop order, with the value divisions in the outer loop, the hue divisions in the middle loop, and the saturation divisions in the inner loop. All zero input saturation entries are required to have a value scale factor of 1.0."
ReductionMatrix3,52538,0xcd3a,Image,Exif.Image.ReductionMatrix3,SRational,"ReductionMatrix3 defines a dimensionality reduction matrix for use as the first stage in converting color camera native space values to XYZ values, under the third calibration illuminant. This tag may only be used if ColorPlanes is greater than 3. The matrix is stored in row scan order."
RGBTables,52539,0xcd3b,Image,Exif.Image.RGBTables,Undefined,"This tag specifies color transforms that can be applied to masked image regions. Color transforms are specified using RGB-to-RGB color lookup tables. These tables are associated with Semantic Masks to limit the color transform to a sub-region of the image. The overall color transform is a linear combination of the color tables, weighted by their corresponding Semantic Masks."
RGBTables,52543,0xcd3f,Image,Exif.Image.RGBTables,Undefined,"This tag specifies color transforms that can be applied to masked image regions. Color transforms are specified using RGB-to-RGB color lookup tables. These tables are associated with Semantic Masks to limit the color transform to a sub-region of the image. The overall color transform is a linear combination of the color tables, weighted by their corresponding Semantic Masks."
ProfileGainTableMap2,52544,0xcd40,Image,Exif.Image.ProfileGainTableMap2,Undefined,"This tag is an extended version of ProfileGainTableMap."
ColumnInterleaveFactor,52547,0xcd43,Image,Exif.Image.ColumnInterleaveFactor,Long,"This tag specifies that columns of the image are stored in interleaved order. The value of the tag specifies the number of interleaved fields. The use of a non-default value for this tag requires setting the DNGBackwardVersion tag to at least 1.7.1.0."
ImageSequenceInfo,52548,0xcd44,Image,Exif.Image.ImageSequenceInfo,Undefined,"This is an informative tag that describes how the image file relates to other image files captured in a sequence. Applications include focus stacking, merging multiple frames to reduce noise, time lapses, exposure brackets, stitched images for super resolution, and so on."
Expand Down