Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doxygen generation #722

Merged
merged 5 commits into from Mar 1, 2019
Merged

Fix doxygen generation #722

merged 5 commits into from Mar 1, 2019

Conversation

piponazo
Copy link
Collaborator

This is far from perfect, but at least now when we enable the CMake option EXIV2_BUILD_DOC we can build the doc target to generate a decent Doxygen documentation.

There is something which is still broken: the generation of the tags HTML pages. It seems that which the deletion of the autotools and makefiles we forgot to make the transition of this documentation building system to CMake. I'll create a new issue on Github to not forget about that.


PROJECT_LOGO =
PROJECT_LOGO = @ROOTDIR@/exiv2.png
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll highlight with comments the parts that I've changed during the update.

This is just to show the logo in every HTML page.


MULTILINE_CPP_IS_BRIEF = NO
MULTILINE_CPP_IS_BRIEF = YES
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this very useful for having one-liners of documentation treated as @brief without using the @brief keyword. For example:

/// My awesome function which does XXX
void awesome();

cmake/Doxyfile.in Outdated Show resolved Hide resolved
@D4N
Copy link
Member

D4N commented Feb 28, 2019

Would you mind cherry-picking or just including the change from 3e27828? That commit predefines the macro PARSED_BY_DOXYGEN when Doxygen parses the code, which I have started to use in the slices implementation to hide internal details and template magic (both don't belong into the API docs).

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files         143      143           
  Lines       18980    18980           
=======================================
  Hits        13200    13200           
  Misses       5780     5780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29713cb...76e919e. Read the comment docs.

piponazo and others added 2 commits March 1, 2019 07:41
This allows us to hide internal namespaces and some template magic which serves
little purpose to have in the API documentation
Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@D4N D4N merged commit 7b34811 into Exiv2:master Mar 1, 2019
@piponazo piponazo mentioned this pull request Mar 2, 2019
@tbeu tbeu added this to the v0.28 milestone Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants