Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for v0.27.1 #782

Merged
merged 6 commits into from Apr 25, 2019
Merged

Changes for v0.27.1 #782

merged 6 commits into from Apr 25, 2019

Conversation

clanmills
Copy link
Collaborator

Gentlemen:

I hope this is v0.27.1. I haven't had any feedback from users.

I've added support for Visual Studio 2019 and updated README.md concerning an issue with the MinGW/Source build. I've retained the fix for #744 which was submitted to v0.27-maintenance. And I've reviewed/revised releasenotes.txt, README.md and README-CONAN.md

I hope this is good to go. I'm sure you'll spot more changes.

When it's good, could you tag this as "v0.27.1". Then I'll get Jenkins to build. I'll test the builds and publish on https://exiv2.org

Let me know if you'd like to have a meeting (1 hour on-line) to talk together. I hope to do "v0.27.2 RC1" by 2019-06-15 and v0.27.2 by 2019-06-30.

@clanmills clanmills added this to the v0.27.1 milestone Apr 18, 2019
@clanmills clanmills self-assigned this Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #782 into 0.27-maintenance will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance     #782   +/-   ##
=================================================
  Coverage             62.67%   62.67%           
=================================================
  Files                   156      156           
  Lines                 21523    21523           
=================================================
  Hits                  13490    13490           
  Misses                 8033     8033
Impacted Files Coverage Δ
src/version.cpp 91.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f3910...7a9c928. Read the comment docs.

Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we intend to support Visual Studio 2019, then we must add a CI job for Appveyor to it.

And don't we still support VS 2010 & 2013 for 0.27?

@clanmills
Copy link
Collaborator Author

Yes, we still support other versions of Visual Studio, however I've made them less prominent. I believe 2008 etc build, however I don't want to say they are actively supported. I've removed 2008/10/12/13 from both the MacMini and my laptop.

I don't know that you need to add a CI/2019 job at the moment. I've tested the Source build on both the MacMini and my laptop. So, the source bundle builds and that's what's being released.

You can add a CI 2019 job to the 'master' branch if you wish. Or you can leave that to @nehaljwani and I to organise using Jenkins.

@piponazo
Copy link
Collaborator

If we intend to support Visual Studio 2019, then we must add a CI job for Appveyor to it.

It is not available yet on Appveyor. I guess they will provide a windows image with VS2019 once the final version is released.

All the changes look good to me except removing the mentions to old versions of Visual Studio. If there is something important to know about Exiv2 0.27 and future versions of it, is that Exiv2 0.27 is C++98 while in master we moved to c++11. I think we should keep those mentions in 0.27 and we can remove them from master.

@clanmills
Copy link
Collaborator Author

OK. I'll say:

  1. Exiv2 v0.27 can be built with VS 2008, 2010, 2012, 2013, 2015 and 2017.
  2. Exiv2 v0.27.1 (and later) can be built with VS 2015, 2017 and 2019.
  3. v0.28 is being "modernised" to C++11 and will not support C++98. We don't expect Exiv2 v0.28 to build with VS 2008, 2010, 2012 or 2013.

I don't think we need CI for VS2019 at the moment. This can be introduced for branch 'master' when AppVeyor supports VS2019. I'll work with Nehal on Jenkins for branch '0.27-maintenance' and support 2015, 2017 and 2019.

@nehaljwani
Copy link
Collaborator

Azure pipelines do support VS 2019 (preview), according to https://devblogs.microsoft.com/devops/hosted-pipelines-announcements-vs-2019-mojave-and-more/

Not saying that we should shift, just FYI.

piponazo
piponazo previously approved these changes Apr 21, 2019
@D4N D4N self-requested a review April 22, 2019 22:01
Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we tag the last commit then as 0.27.1?

@piponazo
Copy link
Collaborator

Should we tag the last commit then as 0.27.1?

How we did it the last time was:

  1. Merge PR into 0.27-maintenance.
  2. Tag the latest commit in 0.27-maintenance.

Otherwise, we could tag a commit and then continue working in the branch without it being merged. Right now the PR is blocked because you requested changes.

@D4N D4N self-requested a review April 23, 2019 14:18
D4N
D4N previously approved these changes Apr 23, 2019
Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this release out!

@clanmills
Copy link
Collaborator Author

The release will go out tomorrow (assuming I don't find a show stopper). Great work by lots of folks. I'm humbled to be working with such talented and professional people. Well done, everybody.

@D4N
Copy link
Member

D4N commented Apr 24, 2019

The release will go out tomorrow (assuming I don't find a show stopper). Great work by lots of folks. I'm humbled to be working with such talented and professional people. Well done, everybody.

Please press the merge button once you are ready @clanmills.

@mergify mergify bot dismissed stale reviews from D4N and piponazo April 25, 2019 18:41

Pull request has been modified.

@piponazo piponazo merged commit 16df09c into 0.27-maintenance Apr 25, 2019
@clanmills clanmills deleted the Changes_for_v0.27.1 branch May 9, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants