New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for v0.27.1 #782
Changes for v0.27.1 #782
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #782 +/- ##
=================================================
Coverage 62.67% 62.67%
=================================================
Files 156 156
Lines 21523 21523
=================================================
Hits 13490 13490
Misses 8033 8033
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we intend to support Visual Studio 2019, then we must add a CI job for Appveyor to it.
And don't we still support VS 2010 & 2013 for 0.27?
Yes, we still support other versions of Visual Studio, however I've made them less prominent. I believe 2008 etc build, however I don't want to say they are actively supported. I've removed 2008/10/12/13 from both the MacMini and my laptop. I don't know that you need to add a CI/2019 job at the moment. I've tested the Source build on both the MacMini and my laptop. So, the source bundle builds and that's what's being released. You can add a CI 2019 job to the 'master' branch if you wish. Or you can leave that to @nehaljwani and I to organise using Jenkins. |
It is not available yet on Appveyor. I guess they will provide a windows image with VS2019 once the final version is released. All the changes look good to me except removing the mentions to old versions of Visual Studio. If there is something important to know about Exiv2 0.27 and future versions of it, is that Exiv2 0.27 is C++98 while in master we moved to c++11. I think we should keep those mentions in 0.27 and we can remove them from master. |
OK. I'll say:
I don't think we need CI for VS2019 at the moment. This can be introduced for branch 'master' when AppVeyor supports VS2019. I'll work with Nehal on Jenkins for branch '0.27-maintenance' and support 2015, 2017 and 2019. |
Azure pipelines do support VS 2019 (preview), according to https://devblogs.microsoft.com/devops/hosted-pipelines-announcements-vs-2019-mojave-and-more/ Not saying that we should shift, just FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we tag the last commit then as 0.27.1
?
How we did it the last time was:
Otherwise, we could tag a commit and then continue working in the branch without it being merged. Right now the PR is blocked because you requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this release out!
The release will go out tomorrow (assuming I don't find a show stopper). Great work by lots of folks. I'm humbled to be working with such talented and professional people. Well done, everybody. |
Please press the merge button once you are ready @clanmills. |
Pull request has been modified.
Gentlemen:
I hope this is v0.27.1. I haven't had any feedback from users.
I've added support for Visual Studio 2019 and updated README.md concerning an issue with the MinGW/Source build. I've retained the fix for #744 which was submitted to v0.27-maintenance. And I've reviewed/revised releasenotes.txt, README.md and README-CONAN.md
I hope this is good to go. I'm sure you'll spot more changes.
When it's good, could you tag this as "v0.27.1". Then I'll get Jenkins to build. I'll test the builds and publish on https://exiv2.org
Let me know if you'd like to have a meeting (1 hour on-line) to talk together. I hope to do "v0.27.2 RC1" by 2019-06-15 and v0.27.2 by 2019-06-30.