-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An integration test for optional results. #151
An integration test for optional results. #151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 96% 95.8% -0.2%
Complexity 153 153
==========================================
Files 52 52
Lines 501 501
Branches 103 103
==========================================
- Hits 481 480 -1
Misses 5 5
- Partials 15 16 +1
Continue to review full report at Codecov.
|
@d4rken More tests are great, thank you! We have a pattern right now for the test package |
Done. I missed that there was an existing structure for this 😅 |
src/test/kotlin/com/expedia/graphql/integration/OptionalResultsTest.kt
Outdated
Show resolved
Hide resolved
Not sure why it is reporting a drop, build and tests are green. LGTM |
* An integration test for optional results. See ExpediaGroup#150 * Refactoring into current package structure. * Cleanup (this will be squashed :o)
Showed me that my error wasn't with this lib.
See #150
We have lot's of modular tests already, a few more integration tests can't hurt 😄 .