An integration test for optional results. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 96% 95.8% -0.2%
Complexity 153 153
==========================================
Files 52 52
Lines 501 501
Branches 103 103
==========================================
- Hits 481 480 -1
Misses 5 5
- Partials 15 16 +1
Continue to review full report at Codecov.
|
|
@d4rken More tests are great, thank you! We have a pattern right now for the test package |
|
Done. I missed that there was an existing structure for this 😅 |
dariuszkuc
reviewed
Jan 22, 2019
src/test/kotlin/com/expedia/graphql/integration/OptionalResultsTest.kt
Outdated
Show resolved
Hide resolved
|
Not sure why it is reporting a drop, build and tests are green. LGTM |
smyrick
approved these changes
Jan 22, 2019
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* An integration test for optional results. See ExpediaGroup#150 * Refactoring into current package structure. * Cleanup (this will be squashed :o)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showed me that my error wasn't with this lib.
See #150
We have lot's of modular tests already, a few more integration tests can't hurt 😄 .