Changes to sdl field of _service object to make it compliant with the…

[tobias-f]

… federation specification

• if the Query type is present, it should have the @extends directive, since it extends the query type
• the default schema definition should not be includeded in the sdl. This causes problems for example with the @apollo/gateway, because if the default schema definition is present, no queries are picked up from the federated schema.

[codecov]

Codecov Report

Merging #304 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
+ Coverage     94.42%   94.44%   +0.01%     
  Complexity      256      256              
============================================
  Files            74       74              
  Lines           915      918       +3     
  Branches        169      169              
============================================
+ Hits            864      867       +3     
  Misses           31       31              
  Partials         20       20

Impacted Files	Coverage Δ	Complexity Δ
...raphql/federation/FederatedSchemaGeneratorHooks.kt	97.82% <100%> (+0.15%)	7 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5812fa0...8e2b80c. Read the comment docs.

[dariuszkuc]

• if the Query type is present, it should have the @extends directive, since it extends the query type

if all Query types are extended then which service defines the base?

• the default schema definition should not be included in the sdl. This causes problems for example with the @apollo/gateway, because if the default schema definition is present, no queries are picked up from the federated schema.

Sounds like a bug in @apollo/gateway - @pcarrier can you take a look?

[dariuszkuc]

Documenting for completeness

• if the Query type is present, it should have the @extends directive, since it extends the query type
  if all Query types are extended then which service defines the base?

Apollo gateway defines the base Query type. Each service that is part of the federated schema should be extending the Query type to signal that its queries are part of a larger federated schema.

• the default schema definition should not be included in the sdl. This causes problems for example with the @apollo/gateway, because if the default schema definition is present, no queries are picked up from the federated schema.

Sounds like a bug in @apollo/gateway - @pcarrier can you take a look?

This still does sound like a bug but indeed there is no need to include those defaults.

[dariuszkuc]

Thanks for the fix!