-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation example #315
Federation example #315
Conversation
Requires an update from graphql-java first graphql-java/graphql-java#1644
@dkuc84 Ah I missed that, ok that means |
@smyrick SDL used by federation is correct but yes there is a mismatch between generated |
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
============================================
+ Coverage 93.56% 93.58% +0.02%
Complexity 267 267
============================================
Files 76 77 +1
Lines 963 967 +4
Branches 176 175 -1
============================================
+ Hits 901 905 +4
Misses 36 36
Partials 26 26
Continue to review full report at Codecov.
|
Maybe we should put all examples under single example folder?, e.g.
thoughts? |
Yea, I was thinking about that. It would make the top level easier to look at. I will update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way we could run both examples during build? unsure about travis but maybe we could utilize github actions?
@dkuc84 I would love to start using actions, but we need the org admins to opt-in to the feature. Right now the maven modules are at least compiled |
* Start a federation example Requires an update from graphql-java first graphql-java/graphql-java#1644 * fix federation example * exclude federation example from code coverage * Move to top-level examples folder
* Start a federation example Requires an update from graphql-java first graphql-java/graphql-java#1644 * fix federation example * exclude federation example from code coverage * Move to top-level examples folder
Add a federation example with two running spring boot apps and a Node.js app running
@apollo/gateway
Here is a query sent to the gateways which resolves data directly from both apps, and also runs a query from
base-app
(getWidgetById
) by then is extended with data fromextend-app