Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalars docs with common issues #772

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Update scalars docs with common issues #772

merged 2 commits into from
Jun 17, 2020

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jun 17, 2020

📝 Description

Add some messages about common issues for scalars so they are searchable in the search bar.

🔗 Related Issues

Resolves #771

@smyrick smyrick added the type: documentation Documentation or test changes label Jun 17, 2020

By default, `graphql-kotlin` only supports the primitive scalar types listed above. If you are looking to use common java types as scalars, you need to include the [graphql-java-extended-scalars](https://github.com/graphql-java/graphql-java-extended-scalars) library and set up the hooks (see above), or write the logic yourself for how to resolve these custom scalars.

The most popular types that require extra configuration are: `LocalDate`, `DateTime`, `Instant`, `ZonedDateTime`, `URL`, `UUID`
Copy link
Contributor Author

@smyrick smyrick Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this line for searchability

@dariuszkuc dariuszkuc merged commit 643aa43 into master Jun 17, 2020
@dariuszkuc dariuszkuc deleted the smyrick-patch-1 branch June 17, 2020 17:51
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

None yet

2 participants