Added extensions and Rate limiting options #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayGreeeen
reviewed
Apr 12, 2024
|
Looks like |
JayGreeeen
reviewed
Apr 12, 2024
Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
JayGreeeen
reviewed
Apr 12, 2024
JayGreeeen
reviewed
Apr 12, 2024
Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
JayGreeeen
reviewed
Apr 12, 2024
waggle-dance-extensions/src/main/java/com/hotels/bdp/waggledance/extensions/ExtensionBeans.java
Outdated
Show resolved
Hide resolved
waggle-dance-extensions/src/main/java/com/hotels/bdp/waggledance/extensions/ExtensionBeans.java
Outdated
Show resolved
Hide resolved
...main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/BucketBandwithProvider.java
Outdated
Show resolved
Hide resolved
...main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/BucketBandwithProvider.java
Outdated
Show resolved
Hide resolved
...om/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandlerTest.java
Outdated
Show resolved
Hide resolved
JayGreeeen
reviewed
Apr 12, 2024
...src/test/java/com/hotels/bdp/waggledance/extensions/WaggleDanceRateLimitIntegrationTest.java
Outdated
Show resolved
Hide resolved
…ce/extensions/ExtensionBeans.java Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
…ce/extensions/ExtensionBeans.java Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
…ce/extensions/client/ratelimit/BucketBandwithProvider.java Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
…ce/extensions/client/ratelimit/BucketBandwithProvider.java Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
…ggledance/extensions/WaggleDanceRateLimitIntegrationTest.java Co-authored-by: Jay Green-Stevens <jaydenegreen@hotmail.com>
jmnunezizu
requested changes
Apr 16, 2024
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Outdated
Show resolved
Hide resolved
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Outdated
Show resolved
Hide resolved
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Outdated
Show resolved
Hide resolved
...om/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandlerTest.java
Show resolved
Hide resolved
jmnunezizu
reviewed
Apr 17, 2024
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Show resolved
Hide resolved
jmnunezizu
requested changes
Apr 17, 2024
...extensions/src/main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/Metrics.java
Outdated
Show resolved
Hide resolved
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Outdated
Show resolved
Hide resolved
...va/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitingInvocationHandler.java
Show resolved
Hide resolved
jmnunezizu
reviewed
Apr 17, 2024
...src/main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/BucketKeyGenerator.java
Outdated
Show resolved
Hide resolved
jmnunezizu
approved these changes
Apr 17, 2024
jmnunezizu
approved these changes
Apr 17, 2024
JayGreeeen
reviewed
Apr 18, 2024
...src/main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/BucketKeyGenerator.java
Show resolved
Hide resolved
JayGreeeen
approved these changes
Apr 18, 2024
DhrubajyotiSadhu
approved these changes
Apr 18, 2024
added release date.
flaming-archer
pushed a commit
to flaming-archer/waggle-dance
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch.📝 Description
Adding extensions module to allow options features to be added to WD.
First one of those features is a Rate Limiting option. This has come out of a lack of rate limiting options we have for the Hive Metastore (HMS). Since Waggle Dance is the proxy in front it is a good point to limit certain.
The underlying problem we're trying to address is performance issues in heavily loaded HMS + RDS causing degradation of service under spiky load.
Please have look at the respective README.md changes in this PR for more information.
🔗 Related Issues