Deploy Checklist: New Expensify 2022-09-09

[OSBotify]

Release Version: 1.1.99-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix "Split bill- Own contact gets highlighted when you press down arrow and the highlight goes out of the screen when press down arrow" #10477
• Toggle staging and production server api #10690
• OptionsSelector - Fix console error #10763
• Create the buildOptimisticReportObject function #10801
• [No QA]Use main for checklist tests #10842
• Add check for team.expensify.com emails for default workspace rooms #10855
• Skip deleted policies when deciding workspace name #10870
• Partial revert of "Use window.location.href for current URL" #10908
• [No QA] Revert "Toggle staging and production server api" #10920
• CP a useless commit to fix failed release #10942

Deploy Blockers:

• [$250] Investigate: 💥 Crash 💥 updateWorkspaceCustomUnit #10876
• Unable to sign in on staging #10917
• [$250] Web - infinite spinner when clicking on Concierge icon, also it displayed as the default icon for new accounts #10925
• Workspace settings - Changes saved offline are not saved when connected to the Internet #10927

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[Julesssss]

@mountiny reverted to resolve the deploy blocker: #10917

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.99-2 🚀

[Julesssss]

Hey @Expensify/applauseleads, I manually added the lock label because we have an important release today. Please take a look at this release checklist when ready :)

[thienlnam]

Checking off 10855 #10855 (comment)

[mountiny]

Checking off 10763 #10763 (comment)

[thienlnam]

Checking off #10690 since the revert in #10920 just removed those changes

[mvtglobally]

We are 40% through regression.
Are we ok to checkoff #10908. It seems from the previous build

[Julesssss]

@mvtglobally yeah 👍

[mvtglobally]

I am going offline for few hrs. We are at 17% left. Should be done soon.

2 Blockers right now
#10925
#10927

[Julesssss]

Checked off #10925 as it's not always reproducible, and isn't a major problem as users can still chat to concierge.

[Julesssss]

I also checked off #10927 as it's not reproducible by three internal employees.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

Given that the release is pretty much clear, I was going to deploy for @yuwenmemon. This would have given Applause some time to run tests on a new release candidate before the US gets online.

Unfortunately, when checking the Firebase console I noticed that this issue is a new regression with a lot of reported crashes that we do not want to release, even if it is not always reproducible. I'm unable to pick this up this morning, but I shared it in Slack here.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.99-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.99-3 has been deployed to staging 🎉

[Julesssss]

A PR was just merged to resolve #10876, but the release failed 😭 Looking into this now.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.99-4 🚀

[Julesssss]

Okay, this one seemed to be successful. Builds are in progress and should be released within an hour 🎉

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.99-4 has been deployed to staging 🎉

[francoisl]

The iOS build was hanging forever so I canceled it. So in short, 1.1.99-4 is deployed everywhere except iOS. I'm rerunning the canceled action now

Stuck/Canceled iOS build: https://github.com/Expensify/App/actions/runs/3038990393/jobs/4893392499
Retry: https://github.com/Expensify/App/actions/runs/3038990393/jobs/4897356125

[mvtglobally]

@francoisl
We got the IOS build around 1.45pm EST.
Not sure if the issue is not in build not publishing, but rather system not updating it published.

[francoisl]

Interesting. The action got stuck after the build was sent to the AppStore, so it makes sense.

So for now, I think we just need to confirm that the regression #10876 is fixed, by running the QA steps from #10937. If those work, we should be able to check the last blocker and deploy.

[francoisl]

The app doesn't crash on Android and iOS when testing #10937, so all the blockers are resolved now.

It's getting late for me right now and I need to go, so either @Julesssss or anyone else can this checklist when you get online if you feel like it, otherwise I'll do it first thing tomorrow morning!

[Julesssss]

I rechecked Firebase and closed the Crash reports linked to the final blocker. Preparing to ship

[Julesssss]