Workspace settings - Changes saved offline are not saved when connected to the Internet

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
   and login with any account
2. Go to settings->Workspace->General settings (create a workspace if it hasn't already been created)
3. Kill the internet connections
4. Change the workspace name and save
5. Go back online

Expected Result:

Changes made offline must be saved

Actual Result:

Changes saved offline are not saved when connected to the Internet

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.99.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5724768_Record_2022-09-09-18-01-10.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I wasn't able to reproduce this on staging web. @kbecciv is this consistently reproducible by the team?

[youssef-lr]

I wasn't able to reproduce this either.

[Julesssss]

I wasn't able to reproduce on web or mWeb either. As the third person to report this I'm going to remove it as a deploy blocker and we can keep the issue open to investigate further.

I briefly saw the old workspace name flash up when my connection was established, maybe that's a hint for why this issue occurs for some users.

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jboniface]

I was also not able to repro this on staging on web. @kbecciv please retest.

[kbecciv]

@jboniface Checking with team, will update you shortly.

[kbecciv]

@jboniface @luacmartins @youssef-lr Unable to reproduce it with build 1.1.99.4

Recording.1099.mp4

[jboniface]

thanks, closing!