Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deleted policies when deciding workspace name #10870

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Sep 7, 2022

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/226947

Tests / QA

  1. Create a new workspace from the + button menu. It should be called <XXXXXX>'s Workspace.

Screen Shot 2022-09-07 at 3 31 17 PM

  1. Delete That workspace from newDot:

Screen Shot 2022-09-07 at 3 31 10 PM

  1. Create a new workspace again. Confirm it has the same name as the old one.

@Gonals Gonals requested a review from a team as a code owner September 7, 2022 14:31
@Gonals Gonals self-assigned this Sep 7, 2022
@melvin-bot melvin-bot bot requested review from grgia and removed request for a team September 7, 2022 14:32
@Gonals Gonals changed the title Alberto deleted policy skip Skip deleted policies when deciding workspace name Sep 7, 2022
Copy link
Contributor

@grgia grgia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgia grgia merged commit 1718572 into main Sep 8, 2022
@grgia grgia deleted the alberto-deletedPolicySkip branch September 8, 2022 11:34
@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2022

@grgia looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Sep 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Sep 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@grgia
Copy link
Contributor

grgia commented Sep 8, 2022

oops I didn't add the C+ checklist, going to remove the emergency label.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2022

🚀 Deployed to staging by @grgia in version: 1.1.99-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants