[$1000] Fix navigating to workspace chat when a new invited user logs in

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
2. Add a new member to the workspace via Manage Members > Invite
3. CMD+F and search the member's name to navigate to their workspace chat
4. Write a couple of messages in the member's workspace chat, then log-out of the admin account
5. Validate the member account and log-in to NewDot
6. Observe that you land in the Concierge DM and not the member's workspace chat

Expected Result:

User should be navigated to the correct chat

Actual Result:

User is not navigated to the correct chat

Workaround:

Manually navigate to the chat

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012abff40d9e607123
• Upwork Job ID: 1688926809469202432
• Last Price Increase: 2023-08-22

[luacmartins]

Coming from this comment, it seems like iOS and android are experiencing some quirk with react navigation.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[techievivek]

Will look into it this week.

[techievivek]

Not overdue.

[techievivek]

I think this might get fixed here

[techievivek]

I will follow the conversation there and see if that would also fix the navigation issue for this case or not.

[techievivek]

I was ooo so looking into it today.

[techievivek]

Seems like the drawer is open and maybe that's why sometime users are not navigated to the workspace chat.

I just tested this and though the drawer state is open it did navigate me to the workspace chat.

I will test it a few more just to be sure and then I will add this issue on HOLD because with navigation refactor this will be automatically fixed as we are switching to stack-based navigation.

[techievivek]

Tested this couple of times and every time it navigated to workspace chat on Android though the drawer state was open.

@luacmartins Do you mind giving it a try just to see if this still happens? Thanks

[luacmartins]

I just tested and it seems like this doesn't work at all anymore on any platform 😢 Looking at the logs, it seems like we are never setting ONYXKEYS.IS_LOADING_REPORT_DATA to false here. Am I missing something?

[techievivek]

This is weird, it worked perfectly for me. This is what I did.

1. Invited a new user to a workspace which created a chat between admin and newly invited user.
2. Added some messages for the invited user in the workspace chat.
3. Logged out from the admin account.
4. Validated the invited user account and logged in to newDot.
5. It right away took me to workspace chat.

I will a screen share recording tomorrow.

[techievivek]

Sorry, I couldn't get time to look into it today. I will share a recording tomorrow for sure.

[techievivek]

Here is a video of it.

Screen.Recording.2022-12-05.at.1.15.43.PM.mov

[techievivek]

@luacmartins Can you please have a look at the video and try this once again.

[luacmartins]

@techievivek it seems to be working for me now 😕

ios.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012abff40d9e607123

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Talha345]

How can I get an policyExpenseChat beta (e.g @expensifail.com) account to reproduce this issue?

[trjExpensify]

On Dev you should have access to all betas.

[techievivek]

@Talha345 Please have a look at the working on beta features section here: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#working-on-beta-features

[luacmartins]

On Dev you should have access to all betas.

@trjExpensify I think that works for internal engineers only, since external contributors use the staging/production API.

[trjExpensify]

Oh, hm.. it's in the contributing.md file though as @techievivek pointed out!

[luacmartins]

Yea, that works to see the UI in the frontend or things that don't depend on the API, but in this case the API won't return the policyExpenseChat so the user won't be able to actually see them.

[Talha345]

Yea, that works to see the UI in the frontend or things that don't depend on the API, but in this case the API won't return the policyExpenseChat so the user won't be able to actually see them.

@luacmartins How can I reproduce this issue then?

[luacmartins]

We'd need to add your email to the beta.

[Talha345]

@luacmartins Can you please add talha.97.mahmood+55@gmail.com?

[luacmartins]

Done! Changes should be live in ~1h.

[Talha345]

Thanks a lot!

[Talha345]

@techievivek @luacmartins When I login using the member account, Concierge chat opens but I also cannot see the chat where the user who invited me sent messages.I can only see the default announce channel of the workspace.Also the drawer opens automatically.

What should be the expected behaviour in this case? Can you please clarify!

[luacmartins]

I'll hand this back to @techievivek since my plate is quite full atm.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @Ollyws, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[techievivek]

I tried reproducing this but it seems to work just fine for me.

Screen.Recording.2023-08-22.at.6.27.53.PM.mov

Screen.Recording.2023-08-22.at.6.26.30.PM.mov

I saw an another bug tho where the "request money" option appeared without interaction. Isn't that unexpected?

[techievivek]

Maybe the order in which these things matter? Let me try with admin inviting the user to the workspace first, and only then the user validates their account.

[techievivek]

Seems to work the other way around as well.

Screen.Recording.2023-08-22.at.6.52.26.PM.mov

@trjExpensify I am unable to reproduce this on my end. 😕

[trjExpensify]

Maybe the nav reboot fixed it then? The drawer should be open btw, so that's expected. I'm happy to close this out, we can circle back if we come across it again. Will leave that call to you and @JmillsExpensify assigned on the issue though!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[techievivek]

Maybe the nav reboot fixed it then?

Jaons did point that out here #12041 (comment), going to close this. Feel free to re-open if this persists.