[$1000] On editing link in the message, app does not consider link inside the edited message as link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any link
4. Edit the link
5. Remove brackets and keep only the link or keep the circular or square brackets around it intact and ensure there is only one link out of the 2

Expected Result:

App should display the link in the text as link

Actual Result:

App displays the link in the text as normal text

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.88-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

link.not.displayed.properly.on.edit.mp4

Recording.37.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679647857747529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cfeeb27b6da4c666
• Upwork Job ID: 1640823186271752192
• Last Price Increase: 2023-03-28

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

This is reproducible. I think I agree with the desired behavior described here too. Basically if there's a website (www.link.com or link.com) we should treat it like a hyperlinked URL in New Expensify.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01cfeeb27b6da4c666

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[daraksha-dk]

@michaelhaxhiu I think we can close this issue as this was the intended behaviour when user tries to remove the link while editing.
Here's the PR that implemented this.

Refer to the QA steps 10 & 11 here

[alex-mechler]

I agree, this is intentional behavior. We want users to be able to unlink things. Thanks for linking the pr @daraksha-dk. Closing this out