Autolink when edititng comments except wehn explicit link removal #13551

markarmanus · 2022-12-13T04:00:59Z

Details

The issue is when we edit a comment that has links we dont autolink them so that you can click on them. This is because we purposely removed autolnking in this PR #9090
The reason we removed it was when a user would delete the link from a comment it would re genrate it again.

The solution is this PR is to always generate a link unles a user explicitly removes it while editing. This requires comapring the original comment and after deleting comment, detecting which links if any the user removed explicitly and delete them.

Fixed Issues

$ #13221
$ #13221 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

No specefic difference on offline. should behave exactly the same as online.

QA Steps

Write a new message to any chat.
(e.g from `` to hello)
edit the message and add a link
(e.g from hello to hello www.google.com)
confirm the link is generated and can be clicked on.
edit message again now add more normal text
(e.g hello [www.google.com](https://www.google.com) to. hello [www.google.com](https://www.google.com) bye)
confirm the link is still there
edit message again and remove the link part and the []
(e.g from hello [www.google.com](www.google.com) bye to hello www.google.com bye)
confirm the link is removed
edit the message again and any text
(e.g from hello www.google.com bye to hello www.google.com bye newText)
confirm the link is generated again.
delete only the () part of the link
(e.g from hello [www.google.com](https://www.google.com) bye newText to hello [www.google.com] newText bye)
confirm the link is removed but the [] are still there. (i.e comment should now be hello [www.google.com] newText bye
add a second link to the message
(e.g from hello [www.google.com] bye newText to hello [www.google.com] bye newText facebook.com)
confirm two links are generated one for google and one for facebook. and the google one is in []
now delete the () part of the facebook link
(e.g from helle [[www.google.com](https://www.google.com)] bye newText [facebook.com](https://www.facebook.com) to helle [[www.google.com](https://www.google.com)] bye newText facebook.com
confirm only the facebook link is deleted.

Note: if the comment has the same link multiple times it could cause odd behaviour but its an edge case so should be okay.

Verify that no errors appear in the JS console

PR Author Checklist

Desktop,Android and IOS

Screen.Recording.2022-12-13.at.12.35.32.AM.mp4

Screenshots/Videos

Web

Screen.Recording.2022-12-15.at.2.45.01.PM.mp4

Mobile Web - Chrome

Screen.Recording.2022-12-15.at.4.06.17.PM.mov

Mobile Web - Safari

Screen.Recording.2022-12-15.at.4.10.13.PM.mov

Desktop

Please refer to video above with all Desktop, Android and IOS

iOS

Please refer to video above with all Desktop, Android and IOS

Android

Please refer to video above with all Desktop, Android and IOS

melvin-bot · 2022-12-13T04:01:05Z

@cead22 @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2022-12-13T14:28:21Z

The code looks good and works well, there are a couple of comments and stylistic issues that need to be addressed

@markarmanus, as per this discussion, could you please add tests for all the cases you tested in the video?

src/libs/actions/Report.js

markarmanus · 2022-12-13T15:10:01Z

@eVoloshchak all comments addressed and extended the testing to include everything in the video.

eVoloshchak · 2022-12-13T15:15:27Z

@eVoloshchak all comments addressed and extended the testing to include everything in the video.

Thanks!
I think @cead22 was talking about the unit tests

cead22 · 2022-12-13T20:18:05Z

Yes, please add unit tests for all the cases you tested manually 🙇

markarmanus · 2022-12-13T23:51:45Z

@cead22 @eVoloshchak Added unit tests. Also for some reason re requesting the review from @eVoloshchak removed @cead22. apologies for that. i dont seem to have premissions to add you again.

markarmanus · 2022-12-14T17:50:59Z

@cead22 @eVoloshchak any updates ?

eVoloshchak · 2022-12-14T17:52:30Z

Reviewing in a couple of hours

markarmanus · 2022-12-15T00:04:02Z

@eVoloshchak @cead22 Sorry to be buggy, but i only have sometime to work on this today and i dont want to miss the 3 days bonus :D would really appreciate if you guys can find the time for it soon. Again apologies

cead22

Sorry, but there's a few items left to polish this PR

src/libs/actions/Report.js

tests/actions/ReportTest.js

markarmanus · 2022-12-15T05:31:11Z

@cead22 Done and no worries at all, thats the entire point of PR reviews. to make sure the code quality is up to snuff. You have a good eye.

eVoloshchak · 2022-12-15T09:30:30Z

@markarmanus, there are a couple of issues left with the PR description

Change the PR title to be more informative, it should reflect what has been done/fixed
Upload a separate video for each platform, following the PR template
PR Author Checklist is failing, I think you just need to copy a new one from here

eVoloshchak · 2022-12-15T09:34:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-12-15.at.11.18.32.mov

Not able to test due to an issue with the back end, using a Desktop video instead

Mobile Web - Chrome

Screen.Recording.2022-12-15.at.11.18.32.mov

Not able to test due to an issue with the back end, using a Desktop video instead

Mobile Web - Safari

Screen.Recording.2022-12-15.at.11.18.32.mov

Not able to test due to an issue with the back end, using a Desktop video instead

Desktop

Screen.Recording.2022-12-15.at.11.18.32.mov

iOS

Screen.Recording.2022-12-15.at.11.15.07.mov

Android

Screen_Recording_20221215-112215_New.Expensify.mp4

-- add screenshots or videos here -->

cead22

@cead22 Done and no worries at all, thats the entire point of PR reviews. to make sure the code quality is up to snuff. You have a good eye.

Thanks for understanding

markarmanus · 2022-12-16T18:22:29Z

@AndrewGable Also no need to apologize always open to improve the code.

src/libs/actions/Report.js

markarmanus · 2022-12-16T20:03:33Z

cc: @eVoloshchak @cead22

OSBotify · 2022-12-17T00:51:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2022-12-17T01:09:53Z

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
TTI	787.761 ms → 820.864 ms (+33.102 ms, +4.2%)
runJsBundle	185.968 ms → 187.233 ms (+1.266 ms, +0.7%)
nativeLaunch	10.129 ms → 10.594 ms (+0.465 ms, +4.6%)
regularAppStart	0.016 ms → 0.014 ms (-0.002 ms, -10.1%)

Show details

Name	Duration
TTI	Baseline Mean: 787.761 ms Stdev: 39.088 ms (5.0%) Runs: 737.7522340007126 741.1830490007997 745.6529820002615 749.0772720016539 752.4258259981871 753.5808000005782 755.9827740006149 758.8155900016427 761.2115149982274 761.6394039988518 762.759472001344 765.9158999994397 767.3703549988568 769.7797710001469 770.0257360003889 786.0559450015426 789.2824199981987 789.658707998693 791.6496590003371 793.4442900009453 795.413504999131 796.2184639982879 803.9495179988444 811.0301310010254 817.8686849996448 836.9137879982591 852.5440489985049 861.4352440014482 867.3746519982815 886.8266890011728 Current Mean: 820.864 ms Stdev: 52.273 ms (6.4%) Runs: 739.2278859987855 768.3503310009837 770.3983099982142 771.3267190009356 771.5155409984291 772.224305998534 778.1988920010626 779.214958999306 783.110011998564 783.4225759990513 783.7271559983492 784.589811000973 795.0935500003397 804.5152899995446 804.6776689998806 811.2334939986467 813.5079139992595 814.6920420005918 815.3123290017247 823.7906140014529 826.000029001385 836.4664990007877 848.6284330002964 862.2920570001006 865.817279998213 873.5885020010173 882.8974509984255 885.1661729998887 907.5501019991934 922.1723809987307 968.0632440000772
runJsBundle	Baseline Mean: 185.968 ms Stdev: 19.909 ms (10.7%) Runs: 157 162 163 165 165 169 169 172 172 174 175 175 177 179 182 182 182 183 185 187 191 191 191 200 200 208 213 215 217 222 242 Current Mean: 187.233 ms Stdev: 21.129 ms (11.3%) Runs: 157 162 165 166 166 167 170 172 173 175 177 178 179 181 182 183 183 184 185 187 191 194 199 202 209 215 219 227 229 240
nativeLaunch	Baseline Mean: 10.129 ms Stdev: 1.408 ms (13.9%) Runs: 8 9 9 9 9 9 9 9 9 9 9 9 10 10 10 10 10 10 10 10 10 10 10 11 11 11 11 13 13 13 14 Current Mean: 10.594 ms Stdev: 1.730 ms (16.3%) Runs: 8 8 8 8 9 9 9 9 9 10 10 10 10 10 10 10 11 11 11 11 11 11 11 12 12 12 12 12 13 13 14 15
regularAppStart	Baseline Mean: 0.016 ms Stdev: 0.001 ms (6.4%) Runs: 0.013712998479604721 0.014281999319791794 0.014364000409841537 0.014403998851776123 0.014729999005794525 0.014730002731084824 0.014812000095844269 0.014974001795053482 0.015096001327037811 0.015177998691797256 0.015258997678756714 0.015339996665716171 0.01534000039100647 0.015420999377965927 0.015421997755765915 0.01550300046801567 0.015828002244234085 0.01586899906396866 0.015990998595952988 0.016072001308202744 0.016113001853227615 0.016154002398252487 0.016316000372171402 0.016439002007246017 0.016479000449180603 0.016520000994205475 0.016683001071214676 0.016805000603199005 0.016885999590158463 0.01741499826312065 0.0185139998793602 Current Mean: 0.014 ms Stdev: 0.001 ms (5.3%) Runs: 0.012816999107599258 0.013020999729633331 0.013062000274658203 0.01314299926161766 0.013386998325586319 0.01342800259590149 0.013468999415636063 0.013509001582860947 0.013672001659870148 0.013833999633789062 0.013915996998548508 0.01395600289106369 0.01395699754357338 0.013996999710798264 0.014038000255823135 0.014119002968072891 0.014201000332832336 0.014364000409841537 0.014688998460769653 0.014810997992753983 0.01493300125002861 0.014933999627828598 0.015055999159812927 0.015136998146772385 0.015177000313997269 0.015217997133731842 0.015380997210741043

OSBotify · 2022-12-20T06:46:49Z

🚀 Deployed to staging by @cead22 in version: 1.2.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-12-21T22:57:41Z

🚀 Deployed to production by @yuwenmemon in version: 1.2.42-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-03-31T13:15:11Z

This PR caused a regression here #16571.
We used to trim draft messages, convert to html and send to the server.
With this PR the process is a little different:

Trim draft messages
Convert to html
Convert to markdown
Convert to html
Send to the server

In step 3, we need to trim the message again as that step undo the trim of step 1

fedirjh · 2023-05-28T23:05:51Z

Hey there! There is a regression from this PR in #18514. When we capitalize the domain of the edited URL, the URL gets removed. Please note that domain names are case-insensitive according to RFC 4343.

aimane-chnaif · 2023-06-06T14:46:35Z

src/libs/actions/Report.js

+ * @returns {Array}
+ */
+const extractLinksInMarkdownComment = (comment) => {
+    const regex = /\[[^[\]]*\]\(([^()]*)\)/gm;


Coming from #18911:
I understand it's difficult to find edge cases but this regex didn't handle such cases like [[test]](test.com)

For consistency, we're now using markdown link regex exported from expensify-common.

parasharrajat · 2023-10-29T18:15:05Z

src/libs/actions/Report.js

@@ -915,7 +981,7 @@ function editReportComment(reportID, originalReportAction, textForNewComment) {
    }

    // Skip the Edit if message is not changed
-    if (originalMessageHTML === htmlForNewComment.trim()) {
+    if (parsedOriginalCommentHTML === htmlForNewComment.trim()) {


There was a case where resaving the edited message without changing the content will parse the link again #29225. Instead, it should not auto-link when it is removed explicitly and the content is not changed.

fix autolinking issue

2bcc19d

markarmanus requested a review from a team as a code owner December 13, 2022 04:01

melvin-bot bot requested review from cead22 and eVoloshchak and removed request for a team December 13, 2022 04:01

add remaining code

ee9db5d

eVoloshchak suggested changes Dec 13, 2022

View reviewed changes

addrss comments

64c91da

add unit tests

63a277a

markarmanus requested review from eVoloshchak and removed request for cead22 December 13, 2022 23:50

remove only

89fd576

cead22 requested changes Dec 15, 2022

View reviewed changes

add code polish based on comments

90a79a6

markarmanus requested review from cead22 and removed request for eVoloshchak December 15, 2022 05:31

markarmanus changed the title ~~Auto Link does not work when editing a comment.~~ Autolink when edititng comments except wehn explicit link removal Dec 15, 2022

cead22 previously approved these changes Dec 15, 2022

View reviewed changes

AndrewGable reviewed Dec 16, 2022

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

change l to L

a76c8c3

markarmanus requested review from eVoloshchak, cead22 and AndrewGable and removed request for eVoloshchak and cead22 December 16, 2022 19:01

AndrewGable approved these changes Dec 16, 2022

View reviewed changes

markarmanus requested review from eVoloshchak and cead22 and removed request for eVoloshchak December 16, 2022 20:25

cead22 approved these changes Dec 17, 2022

View reviewed changes

cead22 merged commit 2483ad0 into Expensify:main Dec 17, 2022

OSBotify mentioned this pull request Dec 20, 2022

Deploy Checklist: New Expensify 2022-12-20 #13723

Closed

34 tasks

eVoloshchak mentioned this pull request Jan 1, 2023

[$1000] Auto link does not work in edit mode #13221

Closed

daraksha-dk mentioned this pull request Mar 28, 2023

[$1000] On editing link in the message, app does not consider link inside the edited message as link #16481

Closed

6 tasks

s77rt mentioned this pull request Mar 31, 2023

[HOLD for payment 2023-04-07] [$1000] Added padding on edited quote message #16571

Closed

6 tasks

fedirjh mentioned this pull request May 28, 2023

[HOLD for payment 2023-05-29] [$1000] Editing link removes the link #18514

Closed

6 tasks

aimane-chnaif reviewed Jun 6, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Jun 6, 2023

[HOLD for payment 2023-06-02] [$1000] Link disappeared after changing link text to be surrounded with square brackets #18911

Closed

6 tasks

parasharrajat mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-27] [$500] App triggers text to link even while save changes on edit message even when no changes is done #29225

Closed

6 tasks

parasharrajat reviewed Oct 29, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autolink when edititng comments except wehn explicit link removal #13551

Autolink when edititng comments except wehn explicit link removal #13551

markarmanus commented Dec 13, 2022 •

edited

Loading

melvin-bot bot commented Dec 13, 2022

eVoloshchak commented Dec 13, 2022 •

edited

Loading

markarmanus commented Dec 13, 2022

eVoloshchak commented Dec 13, 2022 •

edited

Loading

cead22 commented Dec 13, 2022

markarmanus commented Dec 13, 2022

markarmanus commented Dec 14, 2022

eVoloshchak commented Dec 14, 2022 •

edited

Loading

markarmanus commented Dec 15, 2022 •

edited

Loading

cead22 left a comment

markarmanus commented Dec 15, 2022 •

edited

Loading

eVoloshchak commented Dec 15, 2022 •

edited

Loading

eVoloshchak commented Dec 15, 2022 •

edited

Loading

cead22 left a comment

markarmanus commented Dec 16, 2022

markarmanus commented Dec 16, 2022 •

edited

Loading

OSBotify commented Dec 17, 2022

github-actions bot commented Dec 17, 2022

OSBotify commented Dec 20, 2022

OSBotify commented Dec 21, 2022

s77rt commented Mar 31, 2023

fedirjh commented May 28, 2023

aimane-chnaif Jun 6, 2023

aimane-chnaif Jun 6, 2023

parasharrajat Oct 29, 2023

Autolink when edititng comments except wehn explicit link removal #13551

Autolink when edititng comments except wehn explicit link removal #13551

Conversation

markarmanus commented Dec 13, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 13, 2022

eVoloshchak commented Dec 13, 2022 • edited Loading

markarmanus commented Dec 13, 2022

eVoloshchak commented Dec 13, 2022 • edited Loading

cead22 commented Dec 13, 2022

markarmanus commented Dec 13, 2022

markarmanus commented Dec 14, 2022

eVoloshchak commented Dec 14, 2022 • edited Loading

markarmanus commented Dec 15, 2022 • edited Loading

cead22 left a comment

Choose a reason for hiding this comment

markarmanus commented Dec 15, 2022 • edited Loading

eVoloshchak commented Dec 15, 2022 • edited Loading

eVoloshchak commented Dec 15, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

cead22 left a comment

Choose a reason for hiding this comment

markarmanus commented Dec 16, 2022

markarmanus commented Dec 16, 2022 • edited Loading

OSBotify commented Dec 17, 2022

github-actions bot commented Dec 17, 2022

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

OSBotify commented Dec 20, 2022

OSBotify commented Dec 21, 2022

s77rt commented Mar 31, 2023

fedirjh commented May 28, 2023

aimane-chnaif Jun 6, 2023

Choose a reason for hiding this comment

aimane-chnaif Jun 6, 2023

Choose a reason for hiding this comment

parasharrajat Oct 29, 2023

Choose a reason for hiding this comment

markarmanus commented Dec 13, 2022 •

edited

Loading

eVoloshchak commented Dec 13, 2022 •

edited

Loading

eVoloshchak commented Dec 13, 2022 •

edited

Loading

eVoloshchak commented Dec 14, 2022 •

edited

Loading

markarmanus commented Dec 15, 2022 •

edited

Loading

markarmanus commented Dec 15, 2022 •

edited

Loading

eVoloshchak commented Dec 15, 2022 •

edited

Loading

eVoloshchak commented Dec 15, 2022 •

edited

Loading

markarmanus commented Dec 16, 2022 •

edited

Loading