New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-23] [$1000] Room - Room name rename text is translated in chat but not translated to Spanish in LHN #20124
Comments
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease restate the problem that we are trying to solve in this issue. What is the root cause of the problem?Here What changes do you think we should make in order to solve the problem?Translate the phrase from backend and send. Or we can have an ES phrase for What other solutions did you explore?None |
ProposalPlease re-state the problem that we are trying to solve in this issue.When the language is changed to Spanish, the text in the LHN is still in English. What is the root cause of that problem?We are using the last message in the LHN which comes from the backend and just says "Room renamed to..." What changes do you think we should make in order to solve the problem?Instead of displaying the last message, we should simply use the existing translation key ( const lastAction = visibleReportActionItems[report.reportID]
if (lastAction) {
const oldName = lodashGet(lastAction, 'originalMessage.oldName', '');
const newName = lodashGet(lastAction, 'originalMessage.newName', '');
const lastActorDisplayName = lodashGet(visibleReportActionItems[report.reportID], 'person[0].text');
if (lastAction.actionName && lastAction.actionName === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
result.alternateText = lastActorDisplayName + Localize.translate(preferredLocale, 'newRoomPage.renamedRoomAction', {oldName, newName})
}
} What alternative solutions did you explore? (Optional)None |
Job added to Upwork: https://www.upwork.com/jobs/~01b9817b9e53ecc2b4 |
Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
Triggered auto assignment to @neil-marcellini ( |
Not overdue melvin now only came external |
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Room - Room name rename text is translated in chat but not translated to Spanish in LHN has context menu What is the root cause of that problem?The What changes do you think we should make in order to solve the problem?We can create two variables inside Here In es.js
and here in en.js
Instead of displaying the backend message directly, We can check the last action is equal to rename here then on the basis of that we can use the above localize variable to display the correct translated message. Updated code :
Note: As we need Here is the sample video of the solution : proposal.movWhat alternative solutions did you explore? (Optional)NA |
I like @Ollyws proposal here - #20124 (comment) We should do the same for LHN as well. One suggestion is, its fine to just show 🎀👀🎀 cc: @neil-marcellini |
@abdulrahuman5196 the suggestion that you have given is covered in this #20124 (comment), like added translated strings in the respective language file and using the same to display the text in the selected language. can you please relook at this proposal? |
@kamaljitSharma21 Thank your for the proposal. I did check your proposal before approving here. It only a minor suggestion/variation which could have easily changed in PR. |
I agree with @abdulrahuman5196's decision that @Ollyws' proposal #20124 (comment) looks best. I think it might need some small tweaks but we'll handle that in the PR. |
📣 @Ollyws You have been assigned to this job by @neil-marcellini! |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
Although as Melvin says, it took 4 days we did have it ready and approved within the three days. It would be great if this could be taken into consideration. |
Thanks, @neil-marcellini! I'll make sure the bonus is included 👍 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
BZ checklist:
Not a regression. But the implementation was not done until now.
No. I don't think a regression test would be beneficial for this minor translation issue. |
Not overdue, gentle bump @johncschuster |
@dhanashree-sawant / @Ollyws / @abdulrahuman5196 can you please apply to the Upwork job, here? I'll get payment issued shortly! |
Thank you. Applied for the upwork job @johncschuster |
@johncschuster Also applied. Thanks! |
Great! I've extended offers to you both! |
@johncschuster Accepted, thanks! |
Payment has been issued to @Ollyws and @abdulrahuman5196 🎉 I still need to pay @dhanashree-sawant before closing the issue. |
Hi @johncschuster, |
All payments have been issued! 🎉 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should translate LHN text for room rename to Spanish as it does for text in chat
Actual Result:
App translates room rename text in chat but does not translate room rename text in LHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.23.6
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
room.rename.lhn.no.translate.mp4
Recording.2961.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685522100748299
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: