Fix for: Room name rename text is translated in chat but not translated to Spanish in LHN #20479

Ollyws · 2023-06-08T19:22:48Z

Details

Fixed Issues

$ #20124
PROPOSAL: #20124 (comment)

Tests

Open the app
Open any room or create new room
Click on room name in header, change room name using: settings->room name
Change language to Spanish
Verify that room rename text in the LHN has been changed to Spanish
Verify that room rename text in the chat, including "You" ("Tú") has been changed to Spanish

Verify that no errors appear in the JS console

Offline tests

Open the app
Open any room or create new room
Click on room name in header, change room name using: settings->room name
Change language to Spanish
Verify that room rename text in the LHN has been changed to Spanish
Verify that room rename text in the chat, including "You" ("Tú") has been changed to Spanish

QA Steps

Open the app
Open any room or create new room
Click on room name in header, change room name using: settings->room name
Change language to Spanish
Verify that room rename text in the LHN has been changed to Spanish
Verify that room rename text in the chat, including "You" ("Tú") has been changed to Spanish

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

MacOS_Chrome.mp4

Mobile Web - Chrome

Android_Chrome.mp4

Mobile Web - Safari

iOS_Safari.mp4

Desktop

MacOS_Desktop.mp4

iOS

iOS_Native.mp4

Android

Android_Native.mp4

melvin-bot · 2023-06-08T19:22:53Z

@neil-marcellini @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-06-08T19:28:16Z

I have for now just included my original proposal with some minor alterations. Personally I think it looks good with the same text that we have in the chat, is more congruent that way and there seems to be enough space for it, but let me know what you think.

Something that I did notice is that when you change the text to Spanish the You is not translated in the chat:

Happy to fix this too even if it it may be a little out of scope.

abdulrahuman5196 · 2023-06-09T08:58:34Z

@Ollyws

Personally I think it looks good with the same text that we have in the chat, is more congruent that way and there seems to be enough space for it, but let me know what you think.

I am not sure on this. Even for 10+ characters the new room name the text is getting truncated on the default web view. I think its best to go with the current behaviour of Room renamed to and it will also have more space to show new room name and consistent with current behaviour. Actually I don't think we need to show the same text from chat in the LHN anyways.

2)

Something that I did notice is that when you change the text to Spanish the You is not translated in the chat:
Happy to fix this too even if it it may be a little out of scope.

Yeah. that would be great. Kindly confirm on our slack channel on these translations.(LHN rename as well)

Kindly fill in the author's checklist once we have confirmation on these.

Ollyws · 2023-06-09T09:01:06Z

@abdulrahuman5196 Ok, so you're suggesting we create a new translation key for Room renamed to and the spanish translation and use those?

abdulrahuman5196 · 2023-06-09T09:07:06Z

Yes. Thats my suggestion. But During the slack request for translation confirmation itself you can also check if any other text is good. I think this is best IMO but we can always double check with others on the string if you think other is better. No issues on that.
@Ollyws

Ollyws · 2023-06-09T09:11:43Z

@abdulrahuman5196 Ok, I've asked in Slack.

Ollyws · 2023-06-09T12:19:48Z

@abdulrahuman5196 This commit should fix "You" not being translated in the chat as I mentioned here.

Ollyws · 2023-06-09T15:01:03Z

@abdulrahuman5196 Updated as per your suggestions.

src/components/ReportActionItem/RenameAction.js

abdulrahuman5196 · 2023-06-12T10:57:06Z

It seems in fresh login we are not getting lastMessageText and 'No activity Yet' or 'Beginning of ' text is shown in case of different actions like renamed, IOU, tasks. I think we would need a more broader fix to support this similar places/action in the LHN sidebar subtitle to what we had discussed in the slack here - https://expensify.slack.com/archives/C01GTK53T8Q/p1686326271370549?thread_ts=1686301855.618179&cid=C01GTK53T8Q (Could have some backend changes as well)
I will create a separate bug report to start a issue on this, since it out be out of scope of this translation bug.

abdulrahuman5196 · 2023-06-12T11:01:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.27.mp4

Mobile Web - Chrome

Untitled.24.mp4

Mobile Web - Safari

Untitled.28.mp4

Desktop

Untitled.26.mp4

iOS

Untitled.25.mp4

Android

Untitled.29.mp4

src/components/ReportActionItem/RenameAction.js

src/libs/SidebarUtils.js

abdulrahuman5196

Changes looks good and works well. And reviewers check is also complete.

All yours @neil-marcellini

neil-marcellini

Looks great, but I want to understand why we made changes to the RenameAction.

neil-marcellini · 2023-06-13T17:26:28Z

src/components/ReportActionItem/RenameAction.js

+    const currentUserAccountID = lodashGet(props.currentUserPersonalDetails, 'accountID', '');
+    const userDisplayName = lodashGet(props.action, ['person', 0, 'text']);
+    const actorAccountID = lodashGet(props.action, 'actorAccountID', '');
+    const displayName = actorAccountID === currentUserAccountID ? `${props.translate('common.you')}` : `${userDisplayName}`;


Why did we need to make this change to set "You" instead of the user's display name? It seems unnecessary.

@neil-marcellini
This was not part of the issue which we are fixing in LHN, this was a related translation issue where 'you' text was not translated in the chat page for the rename action. @Ollyws mentioned this issue and lended to fix it as well.

Since it was a similar translation issue during room rename action, I was ok with the extra fix as well. Let me know if you think otherwise.

#20479 (comment)

@neil-marcellini I originally mentioned here, I noticed that the 'You' in the chat was not localised to Spanish as you can can see in the linked comment, so I opted to fix that too.

Ah ok I missed that. Thanks for explaining. Please add tests for that part as well.

neil-marcellini

Please fix merge conflicts and then it should be good to go. Please message me on NewDot when it's updated for a quicker review.

neil-marcellini · 2023-06-14T18:05:36Z

src/components/ReportActionItem/RenameAction.js

+    const currentUserAccountID = lodashGet(props.currentUserPersonalDetails, 'accountID', '');
+    const userDisplayName = lodashGet(props.action, ['person', 0, 'text']);
+    const actorAccountID = lodashGet(props.action, 'actorAccountID', '');
+    const displayName = actorAccountID === currentUserAccountID ? `${props.translate('common.you')}` : `${userDisplayName}`;


Ah ok I missed that. Thanks for explaining. Please add tests for that part as well.

neil-marcellini

Great thanks! Abdul's videos show the new test step too so I think we're good to go.

OSBotify · 2023-06-14T18:41:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-14T21:24:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.28-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2023-06-16T18:40:04Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use Localize for renamed report action

0a89e1c

Ollyws requested a review from a team as a code owner June 8, 2023 19:22

melvin-bot bot requested review from abdulrahuman5196 and neil-marcellini and removed request for a team June 8, 2023 19:22

Run prettier

bca944b

Translate 'You' in room rename action

70001fd

Ollyws added 2 commits June 9, 2023 15:58

Added roomRenamedTo translation key

c5eb20d

Implemented roomRenamedTo translation key

291c667

abdulrahuman5196 reviewed Jun 10, 2023

View reviewed changes

src/components/ReportActionItem/RenameAction.js Outdated Show resolved Hide resolved

Use accountID in RenameAction

13befdd

abdulrahuman5196 suggested changes Jun 12, 2023

View reviewed changes

src/components/ReportActionItem/RenameAction.js Outdated Show resolved Hide resolved

src/libs/SidebarUtils.js Outdated Show resolved Hide resolved

Ollyws added 2 commits June 12, 2023 16:56

Use lodashGet for currentUserAccountID

b51cfe3

Use lodashGet for actionName

a43675b

abdulrahuman5196 approved these changes Jun 13, 2023

View reviewed changes

neil-marcellini requested changes Jun 13, 2023

View reviewed changes

neil-marcellini reviewed Jun 14, 2023

View reviewed changes

Ollyws added 2 commits June 14, 2023 19:12

Merge branch 'main' into issue-20124

4cbe70c

Fix lint

7a7d83c

neil-marcellini approved these changes Jun 14, 2023

View reviewed changes

neil-marcellini merged commit 1345605 into Expensify:main Jun 14, 2023
12 checks passed

OSBotify mentioned this pull request Jun 14, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

neil-marcellini mentioned this pull request Jun 15, 2023

[HOLD for payment 2023-06-23] [$1000] Room - Room name rename text is translated in chat but not translated to Spanish in LHN #20124

Closed

6 tasks

Ollyws deleted the issue-20124 branch June 26, 2023 09:30

Ollyws mentioned this pull request Jul 5, 2023

Fix for: Reopened task message does not translate to Spanish in LHN #22277

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for: Room name rename text is translated in chat but not translated to Spanish in LHN #20479

Fix for: Room name rename text is translated in chat but not translated to Spanish in LHN #20479

Ollyws commented Jun 8, 2023 •

edited

melvin-bot bot commented Jun 8, 2023

Ollyws commented Jun 8, 2023 •

edited

abdulrahuman5196 commented Jun 9, 2023 •

edited

Ollyws commented Jun 9, 2023

abdulrahuman5196 commented Jun 9, 2023

Ollyws commented Jun 9, 2023

Ollyws commented Jun 9, 2023

Ollyws commented Jun 9, 2023

abdulrahuman5196 commented Jun 12, 2023

abdulrahuman5196 commented Jun 12, 2023 •

edited

abdulrahuman5196 left a comment

neil-marcellini left a comment

neil-marcellini Jun 13, 2023

abdulrahuman5196 Jun 13, 2023

Ollyws Jun 13, 2023

neil-marcellini Jun 14, 2023

neil-marcellini left a comment

neil-marcellini Jun 14, 2023

neil-marcellini left a comment

OSBotify commented Jun 14, 2023

OSBotify commented Jun 14, 2023

OSBotify commented Jun 16, 2023

Fix for: Room name rename text is translated in chat but not translated to Spanish in LHN #20479

Fix for: Room name rename text is translated in chat but not translated to Spanish in LHN #20479

Conversation

Ollyws commented Jun 8, 2023 • edited

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 8, 2023

Ollyws commented Jun 8, 2023 • edited

abdulrahuman5196 commented Jun 9, 2023 • edited

Ollyws commented Jun 9, 2023

abdulrahuman5196 commented Jun 9, 2023

Ollyws commented Jun 9, 2023

Ollyws commented Jun 9, 2023

Ollyws commented Jun 9, 2023

abdulrahuman5196 commented Jun 12, 2023

abdulrahuman5196 commented Jun 12, 2023 • edited

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Jun 13, 2023

Choose a reason for hiding this comment

abdulrahuman5196 Jun 13, 2023

Choose a reason for hiding this comment

Ollyws Jun 13, 2023

Choose a reason for hiding this comment

neil-marcellini Jun 14, 2023

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Jun 14, 2023

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 14, 2023

OSBotify commented Jun 14, 2023

OSBotify commented Jun 16, 2023

Ollyws commented Jun 8, 2023 •

edited

Ollyws commented Jun 8, 2023 •

edited

abdulrahuman5196 commented Jun 9, 2023 •

edited

abdulrahuman5196 commented Jun 12, 2023 •

edited