[$500] Web - Mini context menu keeps visible after opening Search RHN by Ctrl/CMD + K

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open report page with multiple chat messages.
2. Move the mouse pointer over a message and mini context menu will be shown.
3. Open Emoji Picker by clicking 'Add reaction' button in mini context menu.
4. Press Ctrl/CMD + K to open Search RHN.
5. Close Search RHN and move the mouse pointer over messages.

Expected Result:

Mini context menu should be only shown on hovered message.

Actual Result:

Previously opened mini context menu keeps visible regardless of hover state.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-09-14.09-50-36-145.mp4

Recording.4506.mp4

Expensify/Expensify Issue URL:
Issue reported by: @akamefi202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694699303165169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018c0c625b3a053d7e
• Upwork Job ID: 1702737549085298688
• Last Price Increase: 2023-09-15

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018c0c625b3a053d7e

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[paultsimura]

Possibly a duplicate of #27244

[jliexpensify]

Yep, I think you're right @paultsimura - @mollfpr is also the C+ assigned, so if it isn't a dupe, let me know and I'll re-open this.

[paultsimura]

I was wrong, sorry. While working on the other issue, I found out that this one is a completely different root cause.
@jliexpensify @mollfpr

This issue is actually a regression from #15276

[aimane-chnaif]

@paultsimura please explain the root cause in detail. Why is it a regression from #15276?

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening the search page using cmd+k with the emoji picker open, the mini context menu stays visible.

What is the root cause of that problem?

The emoji picker context menu action has a special function that manually closes the mini context menu on the picker being closed:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 51 to 60 in 4e75989

	const closeContextMenu = (onHideCallback) => {
	if (isMini) {
	closeManually();
	if (onHideCallback) {
	onHideCallback();
	}
	} else {
	hideContextMenu(false, onHideCallback);
	}
	};

However, when navigating, this function is being neglected:

App/src/components/EmojiPicker/EmojiPicker.js

Lines 72 to 78 in a7c53ed

	const hideEmojiPicker = (isNavigating) => {
	if (isNavigating) {
	onModalHide.current = () => {};
	}
	emojiPopoverAnchor.current = null;
	setIsEmojiPickerVisible(false);
	};

What changes do you think we should make in order to solve the problem?

My suggestion is to remove the if (isNavigating) logic here:

    const hideEmojiPicker = (isNavigating) => {
-        if (isNavigating) {
-            onModalHide.current = () => {};
-        }
        emojiPopoverAnchor.current = null;
        setIsEmojiPickerVisible(false);
    };

In #15276, this change was introduced to prevent the Search Input from losing focus on opening. Seems like since then the focusing logic has changed, and if we remove the if (isNavigating) part, the focus still works.

emoji-hide.mp4

What alternative solutions did you explore? (Optional)

[paultsimura]

@aimane-chnaif just posted the proposal with the details.

[bernhardoj]

It's actually a dupe of #23959