[HOLD for payment 2023-04-04] [$4000] Web - NO focus on Search input field when opening FAB menu and then press on CTRL+K

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Sign in with any account
3. Open the Global create (FAB) menu in LHN
4. Press CTRL + K

Expected Result:

Focus on search input field presents

Actual Result:

NO focus on the search input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.2.74.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3191236

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5943528_Recording__3717.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad5855a1dbdb08cf
• Upwork Job ID: 1628172106930155520
• Last Price Increase: 2023-03-16

[MelvinBot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hayata-suenaga]

@MitchExpensify I self assigned this issue. I'm working on Bug0 Triage Checklist but if you could double check it, I would appreciate it.

[MitchExpensify]

Reproduced using the steps in the OP and the issue looks unique from what I can tell @hayata-suenaga !

[hayata-suenaga]

Okay I'll start working on this.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad5855a1dbdb08cf

[MelvinBot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Triggered auto assignment to @cead22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hayata-suenaga]

I'm working on PR for this issue, but I'm stuck. I'd appreciate proposals.

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.90-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• navigate to Search page after fully closing modal on keyboard shortcut #16381

If no regressions arise, payment will be issued on 2023-04-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR: I believe it existed from the beginning, we failed to catch this sooner.
• [@Santhosh-Sellavel / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@Santhosh-Sellavel / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not necessary
• [@MitchExpensify] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/274379

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR: I believe it existed from the beginning, we failed to catch this sooner.
• [@Santhosh-Sellavel / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@Santhosh-Sellavel / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not necessary
• [@MitchExpensify] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/274379

[Santhosh-Sellavel]

@hayata-suenaga

Done with the checklist above, let me know if have any different opinions.

@MitchExpensify
Determine if we should create a regression test for this bug.

I believe we might need for this

Regression Steps

1. Login with any account on the Web/desktop app
2. Click on the FAB menu
3. Press CTRL + K
4. Verify that the FAB menu closes, the Search page opened and the input field is focused automatically.
5. Close the Search page
6. Right click any chat message to show the context menu
7. Press CTRL + Shift + K
8. Verify that the context menu closes, the new group page opened and the input field is focused automatically

[hayata-suenaga]

@Santhosh-Sellavel thank you for the checklist. it looks good to me 👍

[MitchExpensify]

Offers sent to @situchan & @getusha for payment :)

[MelvinBot]

@MitchExpensify, @getusha, @Santhosh-Sellavel, @hayata-suenaga, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@MitchExpensify, @getusha, @Santhosh-Sellavel, @hayata-suenaga, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hayata-suenaga]

@MitchExpensify has the waiting period passed since the PR has been deployed?

[Santhosh-Sellavel]

We are well past that.

[hayata-suenaga]

are we waiting for the TestRail to be added before closing this issue?

[Santhosh-Sellavel]

@MitchExpensify can answer that and payment is also due here

[MitchExpensify]

TestRail update request was added here https://github.com/Expensify/Expensify/issues/274379

Sorry for the delay in payment :) Issued to everyone! Thanks all

(I issued the 50% shared payment between @situchan & @getusha via bonuses)

[situchan]

@MitchExpensify just to confirm if you already considered timeline and decided no bonus. 2 days were weekend.

[MitchExpensify]

It looked like @situchan was assigned here on 3/21/23 6:33 PM EDT

Then the PR was merged 3/27/23 2:06 AM EDT

Based on that, 3 business days would be hit on 3/24/23 6:34 PM EDT

Let me know if I've got anything wrong! 🙇

[getusha]

oh yeah, actually it was approved 3/24/23 and we were waiting for @hayata-suenaga, but i don't think that's how the process works 🙁

Thanks @MitchExpensify!

[situchan]

I asked because of 2 reasons:

• same as @getusha (C+ approval within 3 business days and no further changes requested before merge)
• this is edge case since 2 contributors assigned. @getusha was assigned next day

[MitchExpensify]

Yeah no worries at all! Seeing as no further changes were requested I think there is a case for the bonus to be applied. I'll double check internally as it isn't quite to the letter of the policy 👁️

[MitchExpensify]

After chatting internally we agreed it was fair to issue the early merge bonus @sobitneupane & @getusha - Thanks for flagging and laying out the case! Our goal is to keep things fair generally 😄

[MitchExpensify]

Done!