[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Web - Subscription - No offline indicator on subscription page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #43370

Action Performed:

1. Go to https://staging.new.expensify.com/settings/subscription
2. Go offline

Expected Result:

Offline indicator will appear at the bottom of the page

Actual Result:

Offline indicator does not appear at the bottom of the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510097_1718148973907.20240612_073226.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b0cd5636fae177d
• Upwork Job ID: 1802802935888037908
• Last Price Increase: 2024-06-17
• Automatic offers:
• akinwale | Reviewer | 102781798
• cretadn22 | Contributor | 102781799

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No offline indicator on subscription page

What is the root cause of that problem?

In SubcriptionSettingsPage component we use ScreenWrapper but we don't include shouldShowOfflineIndicatorInWideScreen

App/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx

Line 37 in 4d8d46c

<ScreenWrapper testID={SubscriptionSettingsPage.displayName}>

What changes do you think we should make in order to solve the problem?

Let's add shouldShowOfflineIndicatorInWideScreen to this place

Bonus point 1: Consider to add other props like includeSafeAreaPaddingBottom, style, offlineIndicatorStyle like other pages

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Lines 301 to 310 in 4d8d46c

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={WorkspaceTagsPage.displayName}
	shouldShowOfflineIndicatorInWideScreen
	offlineIndicatorStyle={styles.mtAuto}
	>
	<HeaderWithBackButton
	icon={Illustrations.Tag}
	title={translate('workspace.common.tags')}

Bonus point 2: Consider to incorporate AccessOrNotFoundWrapper outside of the SubscriptionSettingsPage like other pages

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 296 in 4d8d46c

<AccessOrNotFoundWrapper

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[kevinksullivan]

Putting into collect as this is focused on subscription page.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b0cd5636fae177d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[kevinksullivan]

@akinwale please review the proposal above when you get a chance. Thanks!

[akinwale]

We can move forward with @cretadn22's proposal here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pecanoro]

Sounds good, assigning @cretadn22

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cretadn22]

@akinwale My work is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add offline indicator #43936

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @cretadn22 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cretadn22]

@kevinksullivan 🔥 It is time for payment. Thanks

[kevinksullivan]

@akinwale please complete the checklist above

[kevinksullivan]

Paid @cretadn22 , waiting on checklist to pay @akinwale

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Launch Expensify
2. Navigate to the subscriptions settings screen - https://staging.new.expensify.com/settings/subscription
3. Go offline
4. Verify that the offline indicator is displayed at the bottom of the page

Do we agree 👍 or 👎?

[akinwale]

Paid @cretadn22 , waiting on checklist to pay @akinwale

@kevinksullivan Done!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add offline indicator #43936

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @cretadn22 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

waiting on checklist, asked about it here

https://expensify.slack.com/archives/C02NK2DQWUX/p1721067253383449?thread_ts=1720555683.892599&cid=C02NK2DQWUX

[akinwale]

waiting on checklist, asked about it here

https://expensify.slack.com/archives/C02NK2DQWUX/p1721067253383449?thread_ts=1720555683.892599&cid=C02NK2DQWUX

Completed the checklist here: #43558 (comment)

[kevinksullivan]

All set