[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-28] [LOW] [Performance] Refactor ReportActionItem.tsx and MoneyRequestConfirmationList.tsx

[mountiny]

Problem

There is a huge component (>1.1k lines) - ReportActionItem.

Solution

There is an option to pick a scope of the “created” action rendering and move it to a new file. The new file can be called ReportActionItemContentCreated. It is a stateless component and gets props from the parent. Obviously, we can apply React.memo for this child component. This change saves 117 lines of ReportActionItem.

Before: 1118 lines / After: 1001 lines / Diff: 117 lines.
I did some measures and recorded mean value. So It really improves the rendering of the created action.

Before: 2.4ms / After 2.1ms around 15% of improvement.
This change doesn’t have a predictable improvement for text actions, the numbers floats for the legacy and updated versions. However, if the user refresh the page, there is a slight boost.

Before: 3.8ms / After 3.5ms around 9% of improvement.
A commit is here.

cc @rezkiy37

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

I've opened the first PR for review. I will open the second one on Monday.

[rezkiy37]

I've opened the second PR for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Integrate ReportActionItemContentCreated #43693

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist ^ does not apply here. Not a bug

[mountiny]

Also one more PR to go

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[abekkala]

@mountiny does the other PR need to be completed prior to closing this for NewDot payment?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @s77rt owed $250 via NewDot
• Contributor: @rezkiy37 is from an agency-contributor and not due payment

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@abekkala, @s77rt, @mountiny, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

Not overdue. Waiting for #43749 to hit production

[abekkala]

still waiting on #43749 to merge to production

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Integrate MoneyRequestConfirmationListFooter #43749

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @rezkiy37 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$250 to @s77rt once the time comes, no regression testing required

[abekkala]

PAYMENT SUMMARY FOR JULY 10

• Fix: @rezkiy37 - callstack no upwork payment needed
• PR Review: @s77rt [$250] payment via NewDot

[JmillsExpensify]

$250 approved for @s77rt