-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate MoneyRequestConfirmationListFooter #43749
Integrate MoneyRequestConfirmationListFooter #43749
Conversation
…actor/43663-split-money-request-confirmation-list
…actor/43663-split-money-request-confirmation-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this looks good to me. Will complete the checklist / test asap
…actor/43663-split-money-request-confirmation-list
Reviewer Checklist
Screenshots/Videos |
@rezkiy37 can you please fix the conflicts? thanks |
…ation-list' of https://github.com/rezkiy37/Expensify into refactor/43663-split-money-request-confirmation-list
@mountiny I've fixed the conflicts 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I wish we could get rid of the large memos
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.2-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
Details
The PR creates and integrates a new component - MoneyRequestConfirmationListFooter. It takes responsibility for rendering footer content on the Money Request Confirmation page. This change decreases the parent component by 410 lines with some onyx getters, useMemo, etc. Also, I've applied
React.memo()
.I did some measures and recorded the mean value. So It really improves the rendering.
Fixed Issues
$ #43663
PROPOSAL: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1718204702743269
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop