-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] IOU - Category briefly reselects itself when removed #44649
Comments
Triggered auto assignment to @jliexpensify ( |
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Yep, I can reproduce this one - after selecting and deselecting multiple times (e.g. 2 times) the Category reappears briefly again. NOTE: Technically, IOU functionality is under #billpay, but I think this would affect all users so adding it under #collect |
Job added to Upwork: https://www.upwork.com/jobs/~01c03aa025a5c5f612 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Category briefly reselects itself when removed What is the root cause of that problem?There isn't any condition in place which prevents getting reselected itself in App/src/components/SelectionList/BaseListItem.tsx Lines 79 to 82 in 57622ff
What changes do you think we should make in order to solve the problem?Need to set the following condition for already selected item. With this change it will prevent to reselect itself.
What alternative solutions did you explore? (Optional)N/A |
Bump @fedirjh for a review! |
Still awaiting more proposals. |
@pankajsoftyoi Your proposal looks like a reverse solution statement. Can you elaborate more on the root cause of the problem? Can you explain why this bug occurs after multiple selecting and deselecting? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Still awaiting more proposals. |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU - Category briefly reselects itself when removed What is the root cause of that problem?When the user selects and deselects multiple times (e.g. 2 times) the Category reappears briefly again because the previous request finished successfully and updates the Onyx state with a new For example:
The issue is caused because when the user deselects the Category ( In the following video, you can see the steps above, in the Network tab you can see when each request finishes. issue-44649-evidence-request-not-finished.mp4What changes do you think we should make in order to solve the problem?We should change the The loading indicator here should be changed to use the
What alternative solutions did you explore? (Optional)N/A POC poc-issue-44649.mp4 |
@wlegolas Your proposal doesn’t look good to me :
|
Hi @fedirjh thank you for sharing your points. About your point about "Breaking the offline flow" the loading indicator won't be shown because the first condition is to be online:
I recorded the video below to show the offline functionality when the offline-experience.mp4Related to your point "Loading indicator on form", I suggested putting a loading indicator because the application state is not up to date and the If you know another form that had this same problem I can take a look at to find out another solution to solve this problem. |
Issue not reproducible during KI retests. (First week) |
Oh interesting, @fedirjh can you repro this? I wasn't able to. |
I could see this problem when I changed my network connection to a slow one because the main problem was related to the time that the previous request didn't finish with the time the user opened the modal ( |
@jliexpensify @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Waiting on @fedirjh |
@jliexpensify I am still able to reproduce the bug on staging. |
@wlegolas I noticed something in the server response. For other fields, we have two properties: the original one and the modified one. However, for the category field (i.e we have |
Hi @fedirjh I agree with your point about the I simulated locally adding the I can change my proposal to have the implementation to fix it but in my opinion, we have two changes, one in the Frontend project (I can put the details in my current proposal) and another change on the Backend side because the transaction response when updating the Money Request Category needs to return this new field If you agree I can change my proposal to have the information to use the new field |
@wlegolas Can you share details about front end changes? |
Sure, below I'm putting a brief details about the front end changes that we should do to have the
This solution will work properly If the back end returns the If you have any questions or suggestions, please let me know. |
Issue not reproducible during KI retests. (Second week) |
Waiting on @fedirjh |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
I am still able to replicate on staging. |
@jliexpensify @wlegolas After reconsidering, I believe that the current behavior is expected. I can replicate this behavior with other fields that have a list, such as tags and taxes. To reliably reproduce the behavior:
CleanShot.2024-07-22.at.16.45.08.mp4 |
@jliexpensify I think we can just close this for now. |
Ok, that's fair - thanks for doing some additional testing @fedirjh , closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The category should not briefly reselect itself
Actual Result:
The category briefly reselects itself when clicked to remove
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6519586_1718901363324.Screen_Recording_2024-06-20_at_9.31.55_AM.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: