Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xero Export] Push successful report exports to NewDot #44679

Closed
lakchote opened this issue Jul 1, 2024 · 3 comments
Closed

[Xero Export] Push successful report exports to NewDot #44679

lakchote opened this issue Jul 1, 2024 · 3 comments
Assignees
@lakchote
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Jul 1, 2024 •
edited
Loading

Main issue: https://github.com/Expensify/Expensify/issues/409245

See the QBO issue for more context.

When the XeroReportExporter2.java job succeeds, it will call a new MarkAsExported command in Auth that:

  • add an EXPORTINTEGRATION action to the report
  • clear any existing RBR on the report
  • clear the exportFailed rNVP
@lakchote lakchote added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jul 1, 2024
@lakchote lakchote self-assigned this Jul 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Jul 4, 2024

Putting this as a weekly since there are CRITICAL items to handle like #44758

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2024
@lakchote lakchote added Weekly KSv2 and removed Daily KSv2 labels Jul 4, 2024
This was referenced Jul 4, 2024
Closed
Closed
@lakchote lakchote changed the title [Xero Export] Push successful report exports to NewDot [HOLD Web-E #42570] [Xero Export] Push successful report exports to NewDot Jul 10, 2024
@lakchote lakchote changed the title [HOLD Web-E #42570] [Xero Export] Push successful report exports to NewDot [Xero Export] Push successful report exports to NewDot Jul 10, 2024
@lakchote lakchote changed the title [Xero Export] Push successful report exports to NewDot [HOLD Web-E #42570] [Xero Export] Push successful report exports to NewDot Jul 10, 2024
@lakchote
Copy link
Contributor Author

Will be solved by https://github.com/Expensify/Web-Expensify/pull/42570

@lakchote lakchote added the Reviewing Has a PR in review label Jul 10, 2024
@lakchote lakchote changed the title [HOLD Web-E #42570] [Xero Export] Push successful report exports to NewDot [Xero Export] Push successful report exports to NewDot Jul 15, 2024
@lakchote
Copy link
Contributor Author

https://github.com/Expensify/Web-Expensify/pull/42570 got merged.

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakchote lakchote

Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lakchote