Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xero Export] Push Xero auto-sync errors to NewDot #44676

Closed
lakchote opened this issue Jul 1, 2024 · 2 comments
Closed

[Xero Export] Push Xero auto-sync errors to NewDot #44676

lakchote opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Jul 1, 2024

Main issue: https://github.com/Expensify/Expensify/issues/409245
Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.1anhpggeh7wm

Feature Description

  • add errorMessage and isAuthenticationError properties to the IntegrationLastSync data in IS when the XeroSync job fails.
  • add an INTEGRATIONSMESSAGE action to the #admins room for the policy with the error message

Automated Tests

  • Add a test to IS verifying errorMessage and isAuthenticationError are set on the IntegrationLastSync
  • Add an Auth test for SavePolicy verifying that an INTEGRATIONSMESSAGE action gets posted to the #admins room when the last sync is a failure
@lakchote lakchote added Engineering Internal Requires API changes or must be handled by Expensify staff labels Jul 1, 2024
@lakchote lakchote self-assigned this Jul 1, 2024
@lakchote lakchote moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 1, 2024
@lakchote lakchote added the Daily KSv2 label Jul 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 3, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Jul 4, 2024

Same comment as #44679 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2024
@lakchote lakchote added Weekly KSv2 and removed Daily KSv2 labels Jul 4, 2024
@lakchote lakchote changed the title [Xero Export] Push Xero auto-sync errors to NewDot [HOLD Auth #11445] [Xero Export] Push Xero auto-sync errors to NewDot Jul 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2024
@lakchote lakchote changed the title [HOLD Auth #11445] [Xero Export] Push Xero auto-sync errors to NewDot [Xero Export] Push Xero auto-sync errors to NewDot Jul 15, 2024
@lakchote
Copy link
Contributor Author

add errorMessage and isAuthenticationError properties to the IntegrationLastSync data in IS when the XeroSync job fails.

done by https://github.com/Expensify/Integration-Server/pull/7982

add an INTEGRATIONSMESSAGE action to the #admins room for the policy with the error message

already solved by https://github.com/Expensify/Auth/pull/11445

Closing the issue.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant