-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-25] [$250] [Payment card / Subscription] When adding Payment card, there is a slight delay before it shows #44904
Comments
Triggered auto assignment to @mountiny ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Not a blocker since this is behind beta @blimpich I hope you dont mind I will assign you. Are we not handling this optimistically? Feels like we should, but if not there should be some loader |
Yeah this is a bug, we should be handling this optimistically. |
Job added to Upwork: https://www.upwork.com/jobs/~01b996dd4f4317410f |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Triggered auto assignment to @sonialiap ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When adding Payment card, there is a slight delay before it shows What is the root cause of that problem?In the addSubscriptionPaymentCard function, we do not include card information in the optimistic data. Additionally, we do not update the successData when successful or the error in the failure data. What changes do you think we should make in order to solve the problem?In the addSubscriptionPaymentCard function, we must incorporate optimisticData to mirror the backend's response. Furthermore, we should update the successData upon successful execution and the failureData in case of errors. What alternative solutions did you explore? (Optional)Additionally, we could display a skeleton while awaiting the response from the backend (By using addPaymentCardForm.loading from Onyx) |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
if the API is called successfully, the
What alternative solutions did you explore? (Optional) |
@getusha what do you think of the above proposals? |
@dominictb do you think we can have the draft PR in review today? |
|
Nice one! Can you complete the video/screenshots in the OP of the PR linked above? Thanks! |
@blimpich I found another BE bug when calling API |
@dominictb thank you for reporting the bug! I believe that has the same root cause as the first BE bug. Lets come back to that once the first BE bug is completed 👍 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-25. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary: |
@sonialiap, @blimpich, @getusha, @dominictb Eep! 4 days overdue now. Issues have feelings too... |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
$250 approved for @getusha |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #44361
Action Performed:
Expected Result:
User expects that after saving the card data immediately loads and displays
Actual Result:
Several seconds go by before the card actually appears on the Sub page, leading the user to think the details did not save
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6534057_1720183810076.Add_payment_takes_a_while_to_load.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getushaThe text was updated successfully, but these errors were encountered: