-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-29] [$250] Scan - Settings button does not open location permission settings #45431
Comments
Triggered auto assignment to @tgolen ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~01efe1095b2043e581 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
I'm demoting this from a blocker since it doesn't impact product usage. |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
and App/src/components/LocationPermissionModal/index.tsx Lines 35 to 36 in dc5d06b
to:
What alternative solutions did you explore? (Optional) |
This is caused by changes from #39875. @Julesssss Should we consider this as a regression and let author of #39875 to fix this? Or handle this separately as a follow-up improvement |
I think we should handle it like a typical regression. Thanks for finding
that PR!
…On Tue, Jul 16, 2024 at 10:24 AM Eric Han ***@***.***> wrote:
This is caused by changes from #39875
<#39875>.
@Julesssss <https://github.com/Julesssss> Should we consider this as a
regression and let author of #39875
<#39875> to fix this? Or handle this
separately as a follow-up improvement
—
Reply to this email directly, view it on GitHub
<#45431 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMABZQ57WMUL6C3F5TYETZMVCLFAVCNFSM6AAAAABK5LPTTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGM2DINJTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Shared here on the issue. |
@lanitochka17 would you mind confirming the issue here please? I see in the video that the permission prompt is displayed to the user: |
IMO, I think the problem is in step 6 in OP, where we click on "Settings" button but nothing happens on web (on native, it opens the settings screen): Screen.Recording.2024-07-17.at.23.07.06.mov |
Ugh these bloody labels 😭 |
@allroundexperts can you please review this proposal, then we can move forward. thanks |
Bump on the proposal review, @allroundexperts. |
Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
Hey @tienifr, please go ahead with the PR |
PR in progress |
@Julesssss @trjExpensify @allroundexperts @tienifr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Something went wrong. I don't see any browser's location prompt even on |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-08-29. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.7-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Browser location permission access should appear
Actual Result:
The modal closes and the expense is submitted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.2130.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: