[HOLD for payment 2024-08-29] [$250] Scan - Settings button does not open location permission settings

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Click + > Submit expense > Scan
4. Upload a receipt
5. Submit the expense
6. Click Settings

Expected Result:

Browser location permission access should appear

Actual Result:

The modal closes and the expense is submitted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2130.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01efe1095b2043e581
• Upwork Job ID: 1812971045434010011
• Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01efe1095b2043e581

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[tgolen]

I'm demoting this from a blocker since it doesn't impact product usage.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The modal closes and the expense is submitted

What is the root cause of that problem?

• In here, we already have a logic to handle clicking on Settings button.

• In web, Linking.openSettings is undefined so it just close the modal without navigating to settings screen like the native platform.

What changes do you think we should make in order to solve the problem?

• Based on comment:

Another good catch. I think for now it is fine to not trigger any permission flow for web in the blocked flow. By showing the modal we have let them know that they need to enable the permission.

• In case web platform, we should change the title of the Settings button to something like Got it, and click on it just hide the modal. Do it by updating:
  

  App/src/components/LocationPermissionModal/index.tsx

  Line 71 in dc5d06b

  confirmText={hasError ? translate('common.settings') : translate('common.continue')}

  
  to:

            confirmText={hasError ? (Linking.openSettings ? translate('common.settings') : 'Got it') : translate('common.continue')}

and

App/src/components/LocationPermissionModal/index.tsx

Lines 35 to 36 in dc5d06b

	if (hasError && Linking.openSettings) {
	Linking.openSettings();

to:

        if (hasError) {
            if (Linking.openSettings) {
                Linking.openSettings();
            }

• The details can be updated when implementing PR, but just need to make sure, in case of web, we just display the alert that indicates user needs to manually update the location permission, without any CTA "Settings" buttons like other platforms.

What alternative solutions did you explore? (Optional)

[eh2077]

This is caused by changes from #39875.

@Julesssss Should we consider this as a regression and let author of #39875 to fix this? Or handle this separately as a follow-up improvement

[tgolen]

I think we should handle it like a typical regression. Thanks for finding that PR!

…

On Tue, Jul 16, 2024 at 10:24 AM Eric Han ***@***.***> wrote: This is caused by changes from #39875 <#39875>. @Julesssss <https://github.com/Julesssss> Should we consider this as a regression and let author of #39875 <#39875> to fix this? Or handle this separately as a follow-up improvement — Reply to this email directly, view it on GitHub <#45431 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMABZQ57WMUL6C3F5TYETZMVCLFAVCNFSM6AAAAABK5LPTTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGM2DINJTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Julesssss]

Shared here on the issue.

[Julesssss]

@lanitochka17 would you mind confirming the issue here please? I see in the video that the permission prompt is displayed to the user:

[tienifr]

IMO, I think the problem is in step 6 in OP, where we click on "Settings" button but nothing happens on web (on native, it opens the settings screen):

Screen.Recording.2024-07-17.at.23.07.06.mov

[melvin-bot]

@tgolen, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

Ugh these bloody labels 😭

[Julesssss]

@allroundexperts can you please review this proposal, then we can move forward. thanks

[trjExpensify]

Bump on the proposal review, @allroundexperts.

[allroundexperts]

Oh, I already reviewed it here.

@tienifr's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[Julesssss]

Hey @tienifr, please go ahead with the PR

[Julesssss]

PR in progress

[melvin-bot]

@Julesssss @trjExpensify @allroundexperts @tienifr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[tienifr]

Something went wrong. I don't see any browser's location prompt even on main on mWeb. Checking it.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix update settings button title in web #46269

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: