[HOLD for payment 2024-08-14] [Workspace Feeds] Sage intacct - "Expensify Card Settlement Account" Link does not redirect

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-1
Reproducible in staging?: Y
Reproducible in production?: Unable to check , New feature
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Access New Expensify app
2. Sign into a valid account (Beta enabled)
3. Go to Workspace > Accounting > Connect to Sage Intact
4. Go to Card Recon. > Turn toggle ON > Click on "Expensify Card Settlement Account" Link

Expected Result:

Describe what you think should've happened

Actual Result:

Link non functional, Nothing happens, no redirect.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6551044_1721774082047._No_redirect.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[francoisl]

Likely coming from #45415 / cc @koko57 @allgandalf @MariaHCD @mountiny

[francoisl]

Pretty sure this is still behind a beta anyway, also the PR has a lot of commented out code (example function), so I imagine this is something that's still in progress and we can demote for now.

[mountiny]

Yes, thanks for handling, this is behind beta and we are still going to work on this with Callstack

[allgandalf]

not overdue melvin

[koko57]

I can work on this issue

[allgandalf]

This is on staging now...

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: redirect to a proper page from reconciliation account page #46400

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

This appears to be a regression fix per this comment, so I don't think any payments are due in this issue tomorrow 8/14

Closing for now - correct me if I'm wrong though!

[greg-schroeder]

Oops - can you complete the checklist if relevant, though, @allgandalf? Thanks!

[allgandalf]

We can close this one @greg-schroeder , this is part of a project, regression tests would be added at the end of the project, thanks