-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-09-10] [$250] IOU - Message and Notification Swapping in IOU When Transitioning from Offline to Online #46393
Comments
Triggered auto assignment to @greg-schroeder ( |
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Message and Notification Swapping in IOU When Transitioning from Offline to Online What is the root cause of that problem?The root cause of the problem is that the API call to update the date modifies the What changes do you think we should make in order to solve the problem?Updating the sorting logic to ensure that report actions with Add the following code here
What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-08-08 10:23:22 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Messages and notifications swap in IOU when translated from offline to online What is the root cause of that problem?After we update the money request, we call
Then when the queue is unpaused, we merge the pending Onyx data from the response API to Onyx meanwhile other write APIs are not complete. App/src/libs/Network/SequentialQueue.ts Line 179 in 00d2c42
What changes do you think we should make in order to solve the problem?We can remove the
App/src/libs/Network/SequentialQueue.ts Line 161 in 9c7c4a1
What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~017fdfd49bd9346b4c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Hmm won't this have the effect of no Onyx updates being applied until ALL of the API requests are finished? |
@Ollyws Yes, currently if the queue isn't unpause, we still wait until ALL of write API are finished to merge the Onyx update here. App/src/libs/Network/SequentialQueue.ts Line 161 in 207365c
|
@nkdengineer It seems that after adding |
@Ollyws it will be called here after all write APIs are complete. App/src/libs/Network/SequentialQueue.ts Line 161 in 207365c
|
Yes so it's effectively the same as removing |
@Ollyws Yeah, I think it's the same. |
Hmm, it was specifically added this way in #25455, although I'm not exactly sure WHY we're running |
Let me check this again. |
@Ollyws, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Thanks for opening a discussion, I'm just considering any adverse effects and will make a decision. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
I'm still getting essentially the same problem even with Screen.Recording.2024-08-08.at.11.59.09.mov |
Actually I think it was a problem on my end, seems to be working fine now. |
Let's move forward with @nkdengineer's proposal. |
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Huh, @tgolen since you added some comments and concerns about the proposal in this issue, did you want to be assigned to review as well? 🤷 I'm happy to, just checking before I move forward here |
Sure, I wouldn't mind keeping an eye on this one. I'll swap you out |
Okay, thanks @tgolen! Are you able to confirm the contributor assignment? #46393 (comment) |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
OK, yeah. Getting it assigned now. Let's not forget to test this with an ad-hoc build. |
PR is still in review - seems QA identified several issues that'll need to be addressed |
I'm checking with Applause to have those found issues verified against staging to see if they are happening in our main branch of code. If they are reproducible in staging, we can go ahead and merge the PR. If they are not, then @nkdengineer will need to investigate them more. |
It looks like the PR has been merged and deployed to production, so I think this is just waiting on the regression period and payments @greg-schroeder. |
Ah, I guess it didn't get picked up by the automation. 🤔 |
Regression period end 2024-09-10 |
Payment summary: Contributor: @nkdengineer - $250 - Paid via Upwork |
Requested in ND. |
$250 approved for @Ollyws |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Messages and notifications should remain in place
Actual Result:
Messages and notifications swap in IOU when translated from offline to online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6551162_1721788179924.Screen_Recording_2024-07-23_at_7.11.05_PM.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @greg-schroederThe text was updated successfully, but these errors were encountered: