Android - Left half of the new message badge is unresponsive

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue is failing #4603 on Android

Action Performed:

1. Navigate to a conversation with user A
2. Scroll up the conversation
3. As user A send some messages
4. Tap on the left area of the new message badge
   

Expected Result:

Whole badge area should be tappable.

Actual Result:

Left half of the new message badge is unresponsive.

Workaround:

User has to tap the middle or the right area to trigger the button.

Platform:

Where is this issue occurring?

• Android

Version Number: 1.0.86-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

WhatsApp.Video.2021-08-17.at.7.25.10.PM.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

Issue is not reproducible in iOS, button is fully responsive.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

I see that there is a limitation on the Android where the touch area never extends beyond the parent View. I am looking into ways to redesign it so that it receives the touch.

[parasharrajat]

@isagoico Could you please confirm that this is only occurring on Android?

[isagoico]

Just retested in iOS and the button is fully responsive there. Only reproducible in Android.

[parasharrajat]

OK. then I think we have to change the design for Android.
I have an initial draft of what can be done for android but I look more to see what is best. The main motive of this design strategy was to allow the badge to grow as much as it needs while keeping the side areas of it to be available to underneath messages. So that click can activate the menu over messages.

I can calculate the left position based on the badge but that will create a delay as we have to calculate it before rendering it. Let's see what is best.

[parasharrajat]

Let me know guys, if you want me to fix this. The solution is ready.

[parasharrajat]

I have gone ahead pushed a PR to fix this deploy blocker. Is this issue going to be exported?
Consent taken https://expensify.slack.com/archives/C01GTK53T8Q/p1629494267085300.

[Beamanator]

I'll take over this today 👍

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Beamanator]

@jliexpensify Just so you know, @parasharrajat already figured out the issue, created a PR, and @Julesssss and I tested it and merged it this morning. So we're hiring Rajat for the work he already did please 😅

[Beamanator]

Removing Hourly b/c the PR was merged, just waiting for Upwork job & Rajat to be hired (and payment)

[jliexpensify]

Nice, thanks for the heads up. Will tag Rajat once the issue is up!

[jliexpensify]

Created a job in Upwork! cc @parasharrajat

Internal: https://www.upwork.com/ab/applicants/1429942070913818624/job-details
External: https://www.upwork.com/jobs/~013a48ac94f89e06ae

[parasharrajat]

I have applied. Please assign me this issue. Thanks.

[jliexpensify]

Hired!

[isagoico]

Retested this on Android and it was a pass 🎉 Checking it off the checklist and closing

[Beamanator]

I believe this should be reopened to wait for payment, right @jliexpensify ?

[jliexpensify]

Correct, haven't paid Rajat yet :)

[Beamanator]

Ok cool thanks for confirming :)

[Beamanator]

Assigning Rajat since he should have been assigned earlier :D

• Also adding Exported since we have an Upwork job for this

[jliexpensify]

Paying Rajat now and closing, cheers!