Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: marker is not clickable on android #4774

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Fix: marker is not clickable on android #4774

merged 3 commits into from
Aug 23, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 21, 2021 •
edited by Beamanator
Loading

Details

Changed the design for MarkerBadge as touches are not propagated in Android outside the parent which was blocking the click on the half of the Badge.

Fixed Issues

$ #4716

Tests | QA Steps

  1. Navigate to a conversation with user A
  2. Scroll up the conversation
  3. As user, A send some messages
  4. Tap on the left area of the new message badge

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

and-marker.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner August 21, 2021 00:10
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team August 21, 2021 00:11
@Beamanator Beamanator self-requested a review August 23, 2021 09:41
@Beamanator
Copy link
Contributor

@parasharrajat Thanks for testing this on Android, but can you please also test on other platforms to make sure no regressions occurred elsewhere? 👍 (I'll do the same)

Julesssss
Julesssss previously approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well on Desktop, Android, Web.

I have no code review comments 👍

Beamanator
Beamanator previously approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only 2 tiny documentation comments that are NAB 👍 - back to you @Julesssss !

src/pages/home/report/MarkerBadge/MarkerBadgeContainer/MarkerBadgeContainerPropTypes.js Outdated Show resolved Hide resolved
src/pages/home/report/MarkerBadge/MarkerBadgeContainer/MarkerBadgeContainerPropTypes.js Outdated Show resolved Hide resolved
@Beamanator Beamanator self-requested a review August 23, 2021 11:05
Beamanator
Beamanator approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 will merge once tests finish

@Beamanator
Copy link
Contributor

Note: I tested on iOS & mWeb, things look good (so I checked them off the list in the OP)

@Beamanator Beamanator merged commit 5502f86 into Expensify:main Aug 23, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham roryabraham mentioned this pull request Aug 23, 2021
Closed
github-actions bot pushed a commit that referenced this pull request Aug 23, 2021
@Beamanator
Merge pull request #4774 from parasharrajat/newmarker
edb8f91 
Fix: marker is not clickable on android
(cherry picked from commit 5502f86)
@OSBotify OSBotify mentioned this pull request Aug 23, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.0.86-7 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@botify
Copy link

botify commented Aug 25, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-01. 🎊

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 30, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

This was referenced Sep 1, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Sep 3, 2021
Closed
54 tasks
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@Julesssss Julesssss Julesssss left review comments

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@parasharrajat @Beamanator @OSBotify @botify @Julesssss