[HOLD for payment 2021-11-04] Chat - No results found message displayed even when results are found

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log in with any account.
3. Tap + green fab and select "New chat" option
4. On the search box, search any user you have access to

Expected Result:

If a user is found the message ''No result found" hould not be displayed

Actual Result:

No results found message displayed even when results are found for searched user

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
1.91-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5219427_Recording__62.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

@jasperhuangg is going to be schoolin' pretty soon here, so I'm going to grab this deploy blocker from him.

[roryabraham]

I'm unable to reproduce on staging.

[roryabraham]

@kavimuru Can you please refresh and/or retest, because the reproduction steps are not working for me.

[parasharrajat]

@roryabraham I can reproduce this on master. Seems a kind of regression.

[roryabraham]

Hmmm @parasharrajat well out of the newly deployed PRs on the checklist, this one seems like the most likely candidate to have caused a regression here, because it's the only one that altered related code such as OptionListUtils.

[roryabraham]

Maybe it's another beta issue

[isagoico]

I'm also unable to reproduce on my side. Asking the same tester who reported this if he can still repro.

[parasharrajat]

I will check it Rory. Thanks for pointing it out.

[roryabraham]

Also, it might be useful to know if it's only reproducible only for the New Group page or also for Search and/or New Chat

[isagoico]

Figured it out (I think). You have to search for one of the users that are currently included in the recents list. @roryabraham Let me know if that works for you and I'll add it to the Action performed.

[isagoico]

Issue is also reproducible in production. Removing the blocker label.

[roryabraham]

Since this is no longer a time-sensitive deploy blocker, I'm going to unassign myself for now.

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Am I needed on this @MitchExpensify ?

[MitchExpensify]

I unlabeled by mistake :) All good here @dylanexpensify !

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.10-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: No results found issue and refactor & merge NewGroupPage into NewChatPage #5138

If no regressions arise, payment will be issued on 2021-11-04. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[parasharrajat]

@MitchExpensify just bringing to your attention that I have done extra work on the PR for this issue based on this #4993 (comment) request.

@parasharrajat Tangentially related, but IMO there is too much-duplicated code between NewChatPage and NewGroupPage, and also partially SearchPage. I would be willing to pay a small bonus if you spend some time DRYing up that code. Up to you!

According to this, this job should be paid with a bonus for that work which is exclusive of N6-bonus. Thank you.

[MitchExpensify]

Thanks for the heads up @parasharrajat !

[parasharrajat]

Ping for

[MitchExpensify]

Sorry for all these extra actions due to the N6 hold causing old jobs to close in Upwork @parasharrajat . I think this is the last one on my end. Please apply for the new posting here, thanks!

[ALIHASSAN65]

There can be the following reasons:
1- The check is just put on the base of contacts not also on the recent basis.
2- The check put on both the contact and recent basis but not handle in case of recent single base.

This can be resolve with 5 hours.

[opal6502]

Responding to upwork job: https://www.upwork.com/jobs/~0197df495d5d91b0d5

For this issue, my first guess would be that the response from the API is perhaps formatted differently, and the UI isn't displaying anything, because it's unable to parse the response properly?

[mallenexpensify]

@ALIHASSAN65 and @opal6502 this job is completed and awaiting payment. To view open jobs check here https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22

[parasharrajat]

Ping for

[mvtglobally]

Issue not reproducible during KI retests. (Fourth week)
@roryabraham Let us know if you want us to keep checking it in KI retests

[mallenexpensify]

Paid @parasharrajat inc. the n6-hold bonus

[parasharrajat]

@mallenexpensify I think you missed this #4993 (comment) comment here.

[mallenexpensify]

Thanks Rajat, 100% missed that. Since the amount was confirmed and Rory referenced small bonus, I'm going to add another bonus of $250. Let me know if you don't think that's fair.

[parasharrajat]

Sounds good. Something is better than nothing. 🥇

[mallenexpensify]

Done. Thanks for the help Rajat!