[HOLD for payment 2021-10-11] [HOLD for payment 2021-10-07] [Hold for payment 6th Oct] VBA - Step counter displayed from company information

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

#5255 PR step fails

Action Performed:

1. Go to staging.new .expensify.com/bank-account/new
2. Select option "Connect manually"
3. Verify the step counter in routing number/account number entry page

Expected Result:

Step counter below the header of each step should appear (Step 1 of 5)

Actual Result:

No step counter it appears in company information page as step 2 of 5

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.3.0
Reproducible in staging?: Yes
Reproducible in production?: Its a new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub
PR #5255 fails

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[PrashantMangukiya]

If considered as External, this could be Proposed Solution

Need to update line 171 from BankAccountStep.js, Because this.state.bankAccountAddMethod not exist on this page.

App/src/pages/ReimbursementAccount/BankAccountStep.js

Lines 169 to 175 in e1d0220

	<HeaderWithCloseButton
	title={this.props.translate('bankAccount.addBankAccount')}
	stepCounter={this.state.bankAccountAddMethod && {step: 1, total: 5}}
	onCloseButtonPress={Navigation.dismissModal}
	onBackButtonPress={() => setBankAccountSubStep(null)}
	shouldShowBackButton={Boolean(subStep)}
	/>

Solution: On this page, flow is controlled via subStep variable so update line 171 as under.

<HeaderWithCloseButton
  title={this.props.translate('bankAccount.addBankAccount')}
  stepCounter={subStep && {step: 1, total: 5}}     // *** Update this line  ****
  onCloseButtonPress={Navigation.dismissModal}
  onBackButtonPress={() => setBankAccountSubStep(null)}
  shouldShowBackButton={Boolean(subStep)}
/>

Screenshot after update:

[isagoico]

Adding the deploy blocker label since this is failing a PR in the checklist #5255 CC @marcochavezf @stitesExpensify @shawnborton

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[PrashantMangukiya]

If my solution accepted then please message me, I can submit pr with quick fix.

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[TomatoToaster]

@PrashantMangukiya your solution looks good if you can submit a PR, please tag me I can review and submit a CP-staging label so this goes straight to staging on submission.

Since the proposal looks good, @trjExpensify we can hire this contributor for the upwork job.

[PrashantMangukiya]

Hi @TomatoToaster Thanks for the message, I am preparing pr and submitting in few minutes.

[PrashantMangukiya]

@TomatoToaster PR #5584 is ready and submitted.

[trjExpensify]

@PrashantMangukiya job is here on Upwork: https://www.upwork.com/jobs/~015cd98efbae9cc925

[MelvinBot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

@trjExpensify Submitted proposal.

[isagoico]

Retest was a pass!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.3-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pulls/5584\n

If no regressions arise, payment will be issued on 2021-10-07. 🎊

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.4-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pulls/5584\n

If no regressions arise, payment will be issued on 2021-10-11. 🎊

[PrashantMangukiya]

Ping for

[parasharrajat]

Nice @PrashantMangukiya 🤣 this looks familar.

[trjExpensify]

Woah, is there a new Botify in town!? 😉 Paid, thank you!