-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add step counter to VBA flow #5255
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I think I like it more without the |
Yeap, it looks nicer to me without the |
- add subtitle property to Header - add PropTypes for step counter
Code looks good but there's a conflict |
Conflicts: src/pages/ReimbursementAccount/ReimbursementAccountPage.js
Update: fixed merge conflict and removed step counter from the first part of add bank account step. |
Update: I removed the extra spaces I inserted unintentionally in |
hi @stitesExpensify 👋🏽 bumping this :) the props in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @stitesExpensify in version: 1.1.2-9 🚀
|
looks like this PR might have caused some styling regressions #6297 |
Details
A step counter is added in the VBA flow.
Fixed Issues
$ #5074
$ https://github.com/Expensify/Expensify/issues/177670
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android