Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step counter problem corrected on bank account step #5584

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@TomatoToaster Pr is ready, please review it.

Details

Step counter was not displayed on bank account steps, so corrected that problem.

Fixed Issues

$ #5580

Tests | QA Steps

  1. Go to /bank-account/new
  2. Select option "Connect manually"
  3. Verify the step counter in routing number/account number entry page
    QA - Now Step 1 of 5 shows on bank account step.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web

Mobile Web

Mobile Web

Desktop

Desktop

iOS

iOS

Android

Android

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner September 29, 2021 17:09
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team September 29, 2021 17:09
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@TomatoToaster
Copy link
Contributor

Added the CP-Staging label since this resolves a deploy blocker @PrashantMangukiya thanks for getting this up quick. Reviewing and testing it now.

@TomatoToaster
Copy link
Contributor

TomatoToaster commented Sep 29, 2021

Looks good!
image

Just waiting for E2E tests to pass before I merge this. Just note though, it will take a while 🙃

@TomatoToaster TomatoToaster merged commit 8fb214d into Expensify:main Sep 29, 2021
github-actions bot pushed a commit that referenced this pull request Sep 29, 2021
Step counter problem corrected on bank account step

(cherry picked from commit 8fb214d)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @TomatoToaster in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@isagoico
Copy link

isagoico commented Sep 29, 2021

Retest was a pass!
image

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @TomatoToaster in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants