Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and state labels are overlapping with input content and placeholder #5904

Closed
isagoico opened this issue Oct 15, 2021 · 10 comments
Closed
Assignees
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to /bank-account/company
  2. Check the date and state picker

Expected Result:

Label and placeholder should not overlap

Actual Result:

Label and placeholder are overlapping

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
image

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Oct 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Oct 15, 2021
@isagoico
Copy link
Author

Also happening in the invite members box


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with expensifail account
  3. Select any workspace
  4. Go to Manage members and Click invite
  5. Invite 3 users and scroll the box

Expected Result:

Emails should not overlap with the label.

Actual Result:

Text is overlapping with the label.

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Bug5282774_Recording__446.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@isagoico
Copy link
Author

I think this PR might be another possible culprit #5748

@MariaHCD
Copy link
Contributor

For the issue with the incorporation date and state, since we updated the label from State to Incorporation State, the Spanish translations of the labels start overflowing so I'm thinking to just have the two fields on separate rows instead:

Screen Shot 2021-10-18 at 12 17 08 PM

cc: @Gonals

@MariaHCD
Copy link
Contributor

MariaHCD commented Oct 18, 2021

As for the second visual issue, it looks like the label starts overlapping for any textarea with text that overflows:

Screen Shot 2021-10-18 at 12 44 13 PM

cc: @shawnborton

@MariaHCD MariaHCD removed the DeployBlockerCash This issue or pull request should block deployment label Oct 18, 2021
@MariaHCD
Copy link
Contributor

@isagoico I'm thinking the display issue with the multiline text input can be made into a separate GH issue to go through the triage process separately.

@isagoico
Copy link
Author

Opened multiline issue here #5924

@isagoico
Copy link
Author

isagoico commented Oct 19, 2021

There's this other text input in the request a call modal and add PayPal account that are also having a overlapping between the label and the placeholder. @MariaHCD Do you know if this is caused the same or should I open a separate issue for this?

image

@MariaHCD
Copy link
Contributor

@isagoico I believe the issues for the text input in the request call modal and add PayPal account are related to #5924. Let's add these additional screenshots to that issue.

@botify botify closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants