Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change State field in Company Info to 'Incorporation state' #5748

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Change State field in Company Info to 'Incorporation state' #5748

merged 1 commit into from
Oct 11, 2021

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Oct 11, 2021

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180751

Tests/ QA Steps

  1. Log into your account in NewDot and go to an existing workspace.
  2. Select Connect Bank Account and add one manually
  3. In the Company Information Step, make sure the last fields look like this:

Screen Shot 2021-10-11 at 3 15 47 PM

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@Gonals Gonals added the n6-hold label Oct 11, 2021
@Gonals Gonals requested a review from a team October 11, 2021 13:16
@Gonals Gonals self-assigned this Oct 11, 2021
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team October 11, 2021 13:17
@Gonals
Copy link
Contributor Author

Gonals commented Oct 11, 2021

@nkuoch Travis ready!

@nkuoch nkuoch merged commit ed0eae8 into main Oct 11, 2021
@nkuoch nkuoch deleted the alberto-incorporationState branch October 11, 2021 19:19
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico isagoico mentioned this pull request Oct 16, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkuoch nkuoch nkuoch approved these changes

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gonals @OSBotify @nkuoch